doc: update --max-semi-space-size description in cli.md #55495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
cli
This was referenced Oct 22, 2024
RedYetiDev
reviewed
Oct 23, 2024
RedYetiDev
added
the
dont-land-on-v18.x
|
Please amend your commit message to follow the guidelines of commits in this repo. Something similar to your PR title will work. Congrats on your first contribution 🎉 |
|
@RedYetiDev I addressed both of your comments. |
lpinca
approved these changes
Oct 23, 2024
|
Should I lowercase the commit title? |
|
Yes, Update -> update. |
|
@lpinca @RedYetiDev PTAL |
joebowbeer
changed the title
RedYetiDev
added
the
author ready
lpinca
approved these changes
Oct 24, 2024
|
@aduh95 PTAL Is there anything more needed before merging? |
trivikr
approved these changes
Nov 5, 2024
|
Landed in 25f8474 |
aduh95
pushed a commit
that referenced
this pull request
Nov 6, 2024
PR-URL: #55495 Fixes: #55487 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
Nov 6, 2024
PR-URL: #55495 Fixes: #55487 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
tpoisseau
pushed a commit
to tpoisseau/node
that referenced
this pull request
Nov 21, 2024
PR-URL: nodejs#55495 Fixes: nodejs#55487 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #55487