lib: prefer symbol to number in webidl type function
#55737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
approved these changes
Nov 5, 2024
aduh95
added
author ready
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #55737 +/- ##
=======================================
Coverage 88.39% 88.40%
=======================================
Files 654 654
Lines 187728 187729 +1
Branches 36117 36118 +1
=======================================
+ Hits 165948 165956 +8
+ Misses 15015 15007 -8
- Partials 6765 6766 +1
|
github-actions
bot
removed
the
request-ci
LiviaMedeiros
approved these changes
Nov 6, 2024
aduh95
added
the
commit-queue
panva
approved these changes
Nov 6, 2024
targos
approved these changes
Nov 6, 2024
jazelly
approved these changes
Nov 7, 2024
nodejs-github-bot
removed
the
commit-queue
|
Landed in 979526f |
aduh95
added a commit
that referenced
this pull request
Nov 16, 2024
PR-URL: #55737 Reviewed-By: James M Snell <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Jason Zhang <[email protected]>
tpoisseau
pushed a commit
to tpoisseau/node
that referenced
this pull request
Nov 21, 2024
PR-URL: nodejs#55737 Reviewed-By: James M Snell <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Jason Zhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems to be more suited.