Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: fix exclude labels for commit-queue #55809

Closed
wants to merge 1 commit into from
Closed

Conversation

richardlau
Copy link
Member

The gh cli doesn't recognise --no-label. Instead exclude labels via the --search flag.

Refs: #55781 (comment)
Refs: cli/cli#4142

The `gh` cli doesn't recognise `--no-label`. Instead exclude labels
via the `--search` flag.

Refs: #55781 (comment)
Refs: cli/cli#4142
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/actions

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Nov 10, 2024
@marco-ippolito
Copy link
Member

marco-ippolito commented Nov 10, 2024

Weird I find it documented here https://cli.github.com/manual/gh_search_prs

I just realized its different between gh search and list 😅

@marco-ippolito marco-ippolito added the fast-track PRs that do not need to wait for 48 hours to land. label Nov 10, 2024
Copy link
Contributor

Fast-track has been requested by @marco-ippolito. Please 👍 to approve.

LiviaMedeiros pushed a commit that referenced this pull request Nov 10, 2024
The `gh` cli doesn't recognise `--no-label`. Instead exclude labels
via the `--search` flag.

Refs: #55781 (comment)
Refs: cli/cli#4142
PR-URL: #55809
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
@LiviaMedeiros
Copy link
Contributor

Landed in 7bcc250

@aduh95 aduh95 deleted the commit-queue branch November 10, 2024 19:59
aduh95 pushed a commit that referenced this pull request Nov 16, 2024
The `gh` cli doesn't recognise `--no-label`. Instead exclude labels
via the `--search` flag.

Refs: #55781 (comment)
Refs: cli/cli#4142
PR-URL: #55809
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
tpoisseau pushed a commit to tpoisseau/node that referenced this pull request Nov 21, 2024
The `gh` cli doesn't recognise `--no-label`. Instead exclude labels
via the `--search` flag.

Refs: nodejs#55781 (comment)
Refs: cli/cli#4142
PR-URL: nodejs#55809
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Nov 26, 2024
The `gh` cli doesn't recognise `--no-label`. Instead exclude labels
via the `--search` flag.

Refs: nodejs#55781 (comment)
Refs: cli/cli#4142
PR-URL: nodejs#55809
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants