-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools: fix exclude labels for commit-queue #55809
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `gh` cli doesn't recognise `--no-label`. Instead exclude labels via the `--search` flag. Refs: #55781 (comment) Refs: cli/cli#4142
Review requested:
|
nodejs-github-bot
added
the
meta
Issues and PRs related to the general management of the project.
label
Nov 10, 2024
Weird I find it documented here https://cli.github.com/manual/gh_search_prs I just realized its different between |
marco-ippolito
approved these changes
Nov 10, 2024
marco-ippolito
added
the
fast-track
PRs that do not need to wait for 48 hours to land.
label
Nov 10, 2024
Fast-track has been requested by @marco-ippolito. Please 👍 to approve. |
lpinca
approved these changes
Nov 10, 2024
BethGriggs
approved these changes
Nov 10, 2024
LiviaMedeiros
approved these changes
Nov 10, 2024
LiviaMedeiros
pushed a commit
that referenced
this pull request
Nov 10, 2024
The `gh` cli doesn't recognise `--no-label`. Instead exclude labels via the `--search` flag. Refs: #55781 (comment) Refs: cli/cli#4142 PR-URL: #55809 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]>
Landed in 7bcc250 |
aduh95
pushed a commit
that referenced
this pull request
Nov 16, 2024
The `gh` cli doesn't recognise `--no-label`. Instead exclude labels via the `--search` flag. Refs: #55781 (comment) Refs: cli/cli#4142 PR-URL: #55809 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]>
tpoisseau
pushed a commit
to tpoisseau/node
that referenced
this pull request
Nov 21, 2024
The `gh` cli doesn't recognise `--no-label`. Instead exclude labels via the `--search` flag. Refs: nodejs#55781 (comment) Refs: cli/cli#4142 PR-URL: nodejs#55809 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Nov 26, 2024
The `gh` cli doesn't recognise `--no-label`. Instead exclude labels via the `--search` flag. Refs: nodejs#55781 (comment) Refs: cli/cli#4142 PR-URL: nodejs#55809 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
fast-track
PRs that do not need to wait for 48 hours to land.
meta
Issues and PRs related to the general management of the project.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
gh
cli doesn't recognise--no-label
. Instead exclude labels via the--search
flag.Refs: #55781 (comment)
Refs: cli/cli#4142