Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: fixup some minor coverity warnings #56612

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

deps: fixup some minor coverity warnings #56612

wants to merge 1 commit into from
+16 −2

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Jan 15, 2025

Fixes: #56611

@jasnell jasnell requested a review from targos January 15, 2025 13:01
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/crypto
  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. labels Jan 15, 2025
@jasnell jasnell requested a review from anonrig January 15, 2025 13:01
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64520/

@anonrig
Copy link
Member

anonrig commented Jan 15, 2025

cc @nodejs/platform-smartos @nodejs/tsc another case of flaky tests in smartOS, test-net-write-fully-async-buffer: https://ci.nodejs.org/job/node-test-commit-smartos/58641/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64530/

mhdawson
mhdawson approved these changes Jan 16, 2025
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mertcanaltin mertcanaltin mertcanaltin approved these changes

@mhdawson mhdawson mhdawson approved these changes

@UlisesGascon UlisesGascon UlisesGascon approved these changes

@targos targos targos approved these changes

@anonrig anonrig anonrig approved these changes

@benjamingr benjamingr benjamingr approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issues detected by Coverity in ncrypto
8 participants
@jasnell @nodejs-github-bot @anonrig @benjamingr @targos @UlisesGascon @mhdawson @mertcanaltin