Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: test-crypto-scrypt.js doesn't need internals #56673

Merged
merged 1 commit into from
Jan 31, 2025
Merged

test: test-crypto-scrypt.js doesn't need internals #56673

merged 1 commit into from
Jan 31, 2025

Conversation

nektro
Copy link
Contributor

@nektro nektro commented Jan 21, 2025

No description provided.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jan 21, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 21, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.20%. Comparing base (fdad2fa) to head (453fd90).
Report is 87 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #56673   +/-   ##
=======================================
  Coverage   89.20%   89.20%           
=======================================
  Files         662      662           
  Lines      191899   191899           
  Branches    36940    36938    -2     
=======================================
+ Hits       171184   171193    +9     
  Misses      13546    13546           
+ Partials     7169     7160    -9

see 27 files with indirect coverage changes

@VoltrexKeyva VoltrexKeyva added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 21, 2025
@lpinca
Copy link
Member

lpinca commented Jan 21, 2025

FWIW commit title should start with an imperative verb like test: do not use internals in test-crypto-scrypt.js.

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 21, 2025
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64831/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64839/

@richardlau richardlau added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 31, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 31, 2025
@nodejs-github-bot nodejs-github-bot merged commit be9b614 into nodejs:main Jan 31, 2025
70 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in be9b614

@nektro nektro deleted the patch-1 branch January 31, 2025 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@nektro @lpinca @nodejs-github-bot @jasnell @VoltrexKeyva @richardlau