Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Win CI #56678

Closed
wants to merge 3 commits into from
Closed

Win CI #56678

wants to merge 3 commits into from

Conversation

yamachu
Copy link
Contributor

@yamachu yamachu commented Jan 21, 2025

No description provided.

@yamachu
src: use std::u8string instead of std::string to pass path constructor
ceec5cc 
Enforce that it is u8 because it was crashing
when loading files containing Japanese in Windows, cp392 environment.

Fixes: nodejs#56650
@yamachu
fixup! Format changed cpp file
bc1a91e
@yamachu
ci: run test on windows sjis environment
d158360
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/actions

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. meta Issues and PRs related to the general management of the project. needs-ci PRs that need a full CI run. labels Jan 21, 2025
@yamachu yamachu closed this Jan 21, 2025
@yamachu
Copy link
Contributor Author

yamachu commented Jan 21, 2025

Sorry, I thought I had submitted a PR for my repository, but accidentally made it for nodejs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. meta Issues and PRs related to the general management of the project. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yamachu @nodejs-github-bot