Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: fix tools-deps-update #56684

Merged
merged 2 commits into from
Jan 23, 2025
Merged

tools: fix tools-deps-update #56684

merged 2 commits into from
Jan 23, 2025

Conversation

lemire
Copy link
Member

@lemire lemire commented Jan 21, 2025

This extends PR #52957 to our other automated updates.

@targos suggested that this might be more robust.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/actions
  • @nodejs/security-wg

@lemire lemire requested a review from targos January 21, 2025 19:20
@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Jan 21, 2025
@lemire lemire added request-ci Add this label to start a Jenkins CI on a PR. and removed meta Issues and PRs related to the general management of the project. labels Jan 21, 2025
@lemire lemire mentioned this pull request Jan 21, 2025
Open
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 21, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64578/

@aduh95 aduh95 added the meta Issues and PRs related to the general management of the project. label Jan 22, 2025
targos
targos reviewed Jan 22, 2025
View reviewed changes
.github/workflows/tools.yml Outdated Show resolved Hide resolved
@aduh95
Copy link
Contributor

aduh95 commented Jan 22, 2025 •
edited
Loading

@lemire lemire added request-ci Add this label to start a Jenkins CI on a PR.

@lemire Please do not run Jenkins CI on PRs that do not have needs-ci PRs that need a full CI run. , unless you have a reason to test on a platform that's not covered by GHA.

@jasnell
Copy link
Member

jasnell commented Jan 22, 2025

....unless you have a reason to test on a platform that's not covered by GHA.

Just noting... more of an explanation about why would be helpful for folks less familiar with our CI and process.

@lemire lemire requested review from aduh95, jasnell and targos January 22, 2025 16:18
@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 22, 2025
@aduh95 aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Jan 22, 2025
mhdawson
mhdawson approved these changes Jan 22, 2025
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 23, 2025
@nodejs-github-bot nodejs-github-bot merged commit a954602 into nodejs:main Jan 23, 2025
24 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in a954602

aduh95 pushed a commit that referenced this pull request Jan 27, 2025
@lemire @aduh95
tools: fix tools-deps-update
dac1639 
PR-URL: #56684
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@github-actions github-actions bot mentioned this pull request Jan 28, 2025
Merged
aduh95 pushed a commit that referenced this pull request Jan 30, 2025
@lemire @aduh95
tools: fix tools-deps-update
69cb44e 
PR-URL: #56684
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
aduh95 pushed a commit that referenced this pull request Jan 31, 2025
@lemire @aduh95
tools: fix tools-deps-update
78b4c8b 
PR-URL: #56684
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 approved these changes

@mhdawson mhdawson mhdawson approved these changes

@targos targos targos approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lemire @nodejs-github-bot @aduh95 @jasnell @targos @mhdawson