test: enforce strict mode in test-zlib-const #56689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #56689 +/- ##
==========================================
- Coverage 89.21% 89.21% -0.01%
==========================================
Files 662 662
Lines 191934 191934
Branches 36953 36947 -6
==========================================
- Hits 171242 171234 -8
- Misses 13536 13542 +6
- Partials 7156 7158 +2 |
targos
approved these changes
Jan 22, 2025
lpinca
approved these changes
Jan 22, 2025
Instead of checking that assignments fail silently in sloppy mode, check that they throw in strict mode.
|
I rebased to pull in 01dd7c4 from main to fix the unrelated failing tests. Re-approvals would be welcome. |
lpinca
approved these changes
Jan 22, 2025
jasnell
approved these changes
Jan 22, 2025
Trott
added
the
author ready
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 08eeddf |
aduh95
pushed a commit
that referenced
this pull request
Jan 27, 2025
Instead of checking that assignments fail silently in sloppy mode, check that they throw in strict mode. PR-URL: #56689 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
Jan 30, 2025
Instead of checking that assignments fail silently in sloppy mode, check that they throw in strict mode. PR-URL: #56689 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
hvanness
pushed a commit
to hvanness/node
that referenced
this pull request
Jan 30, 2025
Instead of checking that assignments fail silently in sloppy mode, check that they throw in strict mode. PR-URL: nodejs#56689 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
Jan 31, 2025
Instead of checking that assignments fail silently in sloppy mode, check that they throw in strict mode. PR-URL: #56689 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of checking that assignments fail silently in sloppy mode, check that they throw in strict mode.