Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

child_process: allow buffer encoding in spawnSync #6939

Closed
wants to merge 2 commits into from

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented May 23, 2016

Checklist
  • tests and code linting passes
  • a test and/or benchmark is included
  • the commit message follows commit guidelines
Affected core subsystem(s)

child_process

Description of change

When the 'buffer' encoding is passed to spawnSync(), an exception is thrown in Buffer's toString() method because 'buffer' is not a valid encoding there. This commit special cases the 'buffer' encoding.

Fixes: #6930

cjihrig added 2 commits May 23, 2016 17:20
When the 'buffer' encoding is passed to spawnSync(), an exception
is thrown in Buffer's toString() method because 'buffer' is not
a valid encoding there. This commit special cases the 'buffer'
encoding.
This commit refactors test-child-process-spawnsync.js to use
the reusable common.spawnSyncPwd().
@nodejs-github-bot nodejs-github-bot added the child_process Issues and PRs related to the child_process subsystem. label May 23, 2016
@cjihrig cjihrig added the test Issues and PRs related to the tests. label May 23, 2016
@addaleax
Copy link
Member

LGTM pending CI

@bnoordhuis
Copy link
Member

LGTM

@cjihrig
Copy link
Contributor Author

cjihrig commented May 24, 2016

@cjihrig
Copy link
Contributor Author

cjihrig commented May 24, 2016

Thanks for the reviews. Landed in dc76aff and 6bad85c.

@MylesBorins
Copy link
Contributor

@cjihrig lts?

@cjihrig cjihrig deleted the 6930 branch June 3, 2016 01:56
@cjihrig
Copy link
Contributor Author

cjihrig commented Jun 3, 2016

Yep

@MylesBorins MylesBorins mentioned this pull request Jul 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
child_process Issues and PRs related to the child_process subsystem. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants