win,build: try multiple timeservers when signing #9155
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvagg
force-pushed
the
ALL-THE-TIMESERVERS.BAT
branch
from
189c5aa to
1280ed2
Compare
|
Finally worked as I wanted, see the result @ https://nodejs.org/download/test/v8.0.0-test201610181280ed2be7/ |
|
LGTM |
rvagg
force-pushed
the
ALL-THE-TIMESERVERS.BAT
branch
from
1280ed2 to
f612943
Compare
joaocgreis
reviewed
Oct 18, 2016
|
|
||
| for %%s in %timeservers% do ( | ||
| signtool sign /a /d "Node.js" /du "https://nodejs.org" /t %%s %1 | ||
| if ERRORLEVEL 0 if not ERRORLEVEL 1 ( |
There was a problem hiding this comment.
This is just a nit at this point, but if ERRORLEVEL 0 is redundant here. (Ref: http://ss64.com/nt/errorlevel.html )
Also, according to https://msdn.microsoft.com/en-us/library/8s9b9yaz(v=vs.110)#Anchor_6 , perhaps we should also accept exit code 2. But we never did and it's not clear what kind of warnings might happen, so let's just be watchful for binaries signed twice or all servers failing with a different error in the first one.
|
LGTM with or without nit applied |
PR-URL: nodejs#9155 Reviewed-By: Johan Bergström <[email protected]>
|
fixed nit, ignoring exit code 2 for now |
rvagg
force-pushed
the
ALL-THE-TIMESERVERS.BAT
branch
from
f612943 to
f4c20eb
Compare
rvagg
added a commit
that referenced
this pull request
Oct 18, 2016
PR-URL: #9155 Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: João Reis <[email protected]>
rvagg
added a commit
that referenced
this pull request
Oct 18, 2016
PR-URL: #9155 Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: João Reis <[email protected]>
rvagg
added a commit
to rvagg/io.js
that referenced
this pull request
Oct 18, 2016
PR-URL: nodejs#9155 Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: João Reis <[email protected]>
rvagg
added a commit
to rvagg/io.js
that referenced
this pull request
Oct 18, 2016
PR-URL: nodejs#9155 Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: João Reis <[email protected]>
rvagg
added a commit
to rvagg/io.js
that referenced
this pull request
Oct 18, 2016
PR-URL: nodejs#9155 Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: João Reis <[email protected]>
jasnell
pushed a commit
that referenced
this pull request
Oct 18, 2016
PR-URL: #9155 Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: João Reis <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can't get any release builds done right now because globalsign's timeserver isn't responding properly for Authenticode signing requests on Windows!
This PR adds a new file, tools/sign.bat, to do the signing, it tries each of the big available timeservers (globalsign, comodo, verisign, starfield) until it finds one that it can actually use.
Looking for a very speedy review so I can land this and backport to v6, v4, v0.12 and v0.10 and get these releases built! It does work but I've had to make a couple of tweaks while testing. Final testing build should be ready soon in download/release/test/
/cc @nodejs/build @nodejs/platform-windows