src: fix use of uninitialized variable #9280
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the following compiler warning:
../src/node_i18n.cc: In function 'void node::i18n::GetStringWidth(
const v8::FunctionCallbackInfo<v8::Value>&)':
../src/node_i18n.cc:543:15: warning: 'c' may be used uninitialized
in this function [-Wmaybe-uninitialized]
if (!expand_emoji_sequence &&
~~~~~~~~~~~~~~~~~~~~~~~~~
n > 0 && p == 0x200d && // 0x200d == ZWJ (zero width join
Introduced in commit e8eaaa7 ("buffer: add buffer.transcode") from
earlier today.
nodejs-github-bot
added
the
c++
3 tasks
|
Aw, you're right. I'll fix that before landing, thanks. |
jasnell
requested changes
Oct 25, 2016
| @@ -519,14 +519,22 @@ static void GetStringWidth(const FunctionCallbackInfo<Value>& args) { | |||
| } | |||
|
|
|||
| TwoByteValue value(env->isolate(), args[0]); | |||
| if (value.length() <= 1) { | |||
There was a problem hiding this comment.
This additional shortcut is wrong. See the CI failures (https://ci.nodejs.org/job/node-test-commit-osx/5807/nodes=osx1010/console).
There was a problem hiding this comment.
I'm about to go to bed so if you want to take this over, go ahead.
There was a problem hiding this comment.
+1 ... I just went ahead and created a new PR. I'll close this one in favor of that and we can follow up there. Thank you @bnoordhuis !
3 tasks
|
Closing in favor of #9281 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R=@jasnell or @srl295?
CI: https://ci.nodejs.org/job/node-test-pull-request/4671/
EDIT: Make that https://ci.nodejs.org/job/node-test-pull-request/4672/ - I added a static_assert.