add Windows packages and win-arm files support #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for Windows binary package distribution files (zip and 7z). Add support for Windows arm binary distribution files (currently used in "Node.js on ChakraCore" releases). Add tests to transform-filename.js.
Closed
joaocgreis
approved these changes
Oct 27, 2017
joaocgreis
pushed a commit
that referenced
this pull request
Nov 2, 2017
Add support for Windows binary package distribution files (zip and 7z). Add support for Windows arm binary distribution files (currently used in "Node.js on ChakraCore" releases). Add tests to transform-filename.js. PR-URL: #5 Reviewed-By: João Reis <[email protected]>
|
Landed in b1ba460 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for Windows binary package distribution files (zip and 7z).
Add support for Windows arm binary distribution files (currently used in "Node.js on ChakraCore" releases).
Add tests to transform-filename.js.
This PR includes the commit under review in #4 by @rvagg , so this can be easily rebased after that PR lands.