Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-post.js script should ignore 32-bit binaries for intel and sunos #1769

Closed
rvagg opened this issue Aug 16, 2018 · 1 comment
Closed

release-post.js script should ignore 32-bit binaries for intel and sunos #1769

rvagg opened this issue Aug 16, 2018 · 1 comment

Comments

@rvagg
Copy link
Member

rvagg commented Aug 16, 2018

I'd fix this but I'm currently doing releases and am likely to be too exhausted at the end to get around to this.

./scripts/release-post.js needs to not put "Coming soon" for 32-bit binaries for Linux x86 or "sunos" x86 for Node 10+, they're deprecated. But it should still do it for 6 & 8. I think the best way might be to put metadata in scripts/helpers/downloads.js to indicate this and filter them out when we're doing a v10 release.
@ghost ghost mentioned this issue Aug 18, 2018
Merged
ghost pushed a commit that referenced this issue Aug 19, 2018
Add filters for Nodejs 10 (#1772)
f0818db 
1) Ref: #1769
2) Optimize the logic process for module.exports of download.js.i
@ghost
Copy link

ghost commented Aug 20, 2018

Well, this issue is fixed and landed here: f0818db

So I closed this and for any other problems, please feel free to re-open.
Thanks anyway!

@ghost ghost closed this as completed Aug 20, 2018
@targos targos mentioned this issue Sep 20, 2018
Closed
@ghost ghost mentioned this issue Apr 8, 2019
Closed
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rvagg