-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Node.js Everywhere copy from weekly to monthly #1747
Conversation
👍 |
Great, now we need someone to check the other translations as well ... ;) |
As an overview, the following strings would need to be updated:
|
For the Italian translation above you can use "la newsletter mensile di Node.js" |
c914d2c
to
22f936c
Compare
@lpinca Thank you 👍 I’ve changed it. @fhemberger Should I mention the respective localization teams or should we just merge this as is and update the other languages as we go along? |
Thanks @sonicdoe,Please add this :) 【For zh-CN】 【For zh-TW】 /cc: I've also called these related translators to help to contribute their language translations here, you can copy and paste them when they are free to contribute. |
22f936c
to
2f4ae42
Compare
@sonicdoe Japanese version doesn't use the term "weekly" in their description at all as far as I can tell. French should be "hebdomadaire" -> "mensuel". |
2f4ae42
to
8ede424
Compare
@fhemberger Thanks, done 👍 Only Arabic left. |
@sonicdoe actually in French it should be |
8ede424
to
8ac72a0
Compare
@oncletom Ahhhh, sorry for that! |
@fhemberger no probs at all! Thank you for taking care of this PR with @sonicdoe 🙂 |
For the Arabic version if you need to say weekly newsletter about Node.js it should be: Let me know if you need further help 😃 |
Co-authored-by: Luigi Pinca <[email protected]> Co-authored-by: Maledong <[email protected]> Co-authored-by: Thomas Parisot <[email protected]> Co-authored-by: Manel Rhaiem <[email protected]>
8ac72a0
to
b76a0cf
Compare
@mermi Awesome, thank you so much! 😍 |
Resolves #1745. The copy is updated on both the home page and the “Get Involved” page.