-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade to next 15 #7155
Open
ovflowd
wants to merge
37
commits into
main
Choose a base branch
from
chore/nextjs-15
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+5,454
−11,147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
github-actions
bot
removed
the
github_actions:pull-request
Trigger Pull Request Checks
label
Oct 31, 2024
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
github-actions
bot
removed
the
github_actions:pull-request
Trigger Pull Request Checks
label
Oct 31, 2024
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
ovflowd
commented
Oct 31, 2024
github-actions
bot
removed
the
github_actions:pull-request
Trigger Pull Request Checks
label
Oct 31, 2024
Lighthouse Results
|
This comment was marked as resolved.
This comment was marked as resolved.
github-actions
bot
removed
the
github_actions:pull-request
Trigger Pull Request Checks
label
Nov 15, 2024
@leerob I was able to temporarily escape the Build issues by making the optional catch-all a regular catch-all and creating another route. |
cc @nodejs/nodejs-website this PR now is fully functional and ready for review! |
github-actions
bot
removed
the
github_actions:pull-request
Trigger Pull Request Checks
label
Nov 15, 2024
github-actions
bot
removed
the
github_actions:pull-request
Trigger Pull Request Checks
label
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to upgrade to Next.js 15 with the following changes:
next-intl
to the latest version, which required refactoring on its usage for complianceWe avoid building OG on static exports as they are costly to compute. Static exports should not support OG images at the moment.
with
instead ofassert