Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade to next 15 #7155

Open
wants to merge 37 commits into
base: main
Choose a base branch
from
Open

chore: upgrade to next 15 #7155

wants to merge 37 commits into from

Conversation

ovflowd
Copy link
Member

@ovflowd ovflowd commented Oct 30, 2024

This PR attempts to upgrade to Next.js 15 with the following changes:

  • Updated also dependencies, such as next-intl to the latest version, which required refactoring on its usage for compliance
  • Updated all our dynamic segments and routes to be more performant (build only what is needed in a minimal build, actually make it compatible with static exports)
    We avoid building OG on static exports as they are costly to compute. Static exports should not support OG images at the moment.
  • Updates usages of JSON imports to use with instead of assert
  • Updated all other dependencies and fixed issues as needed
  • Updated Storybook to use the plain React version of Storybook as we don't use any specific Next.js feature that should run on Storybook.

Copy link

vercel bot commented Oct 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Nov 15, 2024 2:33am

@ovflowd

This comment was marked as resolved.

@ovflowd

This comment was marked as resolved.

@ovflowd

This comment was marked as resolved.

@AugustinMauroy

This comment was marked as resolved.

@amannn

This comment was marked as resolved.

@ovflowd

This comment was marked as resolved.

@ovflowd

This comment was marked as resolved.

@ovflowd

This comment was marked as resolved.

@ovflowd ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Oct 31, 2024
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Oct 31, 2024
@ovflowd

This comment was marked as resolved.

@eps1lon

This comment was marked as resolved.

@ovflowd ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Oct 31, 2024
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Oct 31, 2024
@ovflowd

This comment was marked as resolved.

@ovflowd ovflowd marked this pull request as ready for review October 31, 2024 20:45
@ovflowd ovflowd requested review from a team as code owners October 31, 2024 20:45
@ovflowd

This comment was marked as resolved.

@ovflowd ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Oct 31, 2024
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Oct 31, 2024
Copy link

github-actions bot commented Nov 14, 2024

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 98 🟢 100 🟢 96 🟢 91 🔗
/en/about 🟢 100 🟢 100 🟢 96 🟢 91 🔗
/en/about/previous-releases 🟢 100 🟢 100 🟢 96 🟢 92 🔗
/en/download 🟢 98 🟢 100 🟢 96 🟢 91 🔗
/en/blog 🟢 99 🟢 100 🟢 96 🟢 92 🔗

@RedYetiDev

This comment was marked as resolved.

@ovflowd
Copy link
Member Author

ovflowd commented Nov 15, 2024

@leerob I was able to temporarily escape the Build issues by making the optional catch-all a regular catch-all and creating another route.

@ovflowd
Copy link
Member Author

ovflowd commented Nov 15, 2024

cc @nodejs/nodejs-website this PR now is fully functional and ready for review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants