CI: Static export locale #7409
CI: Static export locale #7409
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
I didn't get why we need that ? |
lazy consensus from a thread at https://openjs-foundation.slack.com/archives/CVAMEJ4UV/p1735409553256659 |
There was a problem hiding this comment.
I just checked, cause I want to make sure the crowdin build preview in vercel triggers off of the PR, not the push.
The logic uses VERCEL_GIT_COMMIT_REF which is the branch name, so we should be good
| - name: Build Next.js (Static All Locales) | ||
| # We only run full static builds within Pull Requests. This step is also used to export | ||
| # static output in all languages, and it only works on `push` events. | ||
| if: github.event_name == 'push' |
There was a problem hiding this comment.
IMO this should only run against main branch I think; Also @bmuenzenmeyer we need to update branch protection rules to allow the PR to be ✅ with only the default locale,
There was a problem hiding this comment.
IMO this should only run against main branch I think
Does this section not meet this condition? 🤔
I checked the pages where |
Description
With this PR we aim to only export the default language statically instead of statically exporting all pages based on environment variables
Check List
npm run formatto ensure the code follows the style guide.npm run testto check if all tests are passing.npx turbo buildto check if the website builds without errors.