Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed 'Invalid non-string/buffer chunk' error when using Uint8Array #266

Closed
wants to merge 3 commits into from
Closed

Fixed 'Invalid non-string/buffer chunk' error when using Uint8Array #266

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
36402bd
Changed chunk validator to allow Uint8Array
e-avidan Mar 17, 2017
2627841
Changed chunk validator to allow Uint8Array
e-avidan Mar 17, 2017
8cb6cc2
Merge remote-tracking branch 'origin/master'
e-avidan Mar 17, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions lib/_stream_readable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,11 +394,10 @@ Readable.prototype.read = function (n) {
};

function chunkInvalid(state, chunk) {
var er = null;
if (!Buffer.isBuffer(chunk) && typeof chunk !== 'string' && chunk !== null && chunk !== undefined && !state.objectMode) {
er = new TypeError('Invalid non-string/buffer chunk');
}
return er;
if (chunk || Buffer.isBuffer(chunk) || typeof chunk === 'string' || chunk instanceof Uint8Array || state.objectMode)
return null;

return new TypeError('Invalid non-string/buffer chunk');
}

function onEofChunk(stream, state) {
Expand Down Expand Up @@ -938,4 +937,4 @@ function indexOf(xs, x) {
if (xs[i] === x) return i;
}
return -1;
}
}