Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wasm SIMD unsupported #2934

Closed
Simkav opened this issue Mar 7, 2024 · 11 comments · Fixed by #2935
Closed

Wasm SIMD unsupported #2934

Simkav opened this issue Mar 7, 2024 · 11 comments · Fixed by #2935
Labels
bug Something isn't working

Comments

@Simkav
Copy link

Simkav commented Mar 7, 2024

Bug Description

When using last version 6.7.0 on request\fetch getting error

node:internal/process/promises:289
triggerUncaughtException(err, true /* fromPromise */);
^

[CompileError: WebAssembly.compile(): Compiling function #66 failed: Wasm SIMD unsupported @+5368]

Reproducible By

npm i undici
call request or fetch function

Expected Behavior

Expect to get response)

Logs & Screenshots

undici

Environment

Ubuntu 22.04.1 LTS
Node 20.11.1 || 18.7.0
undici 6.7.0

Additional context

If using previos version 6.6.2 everything work

@Simkav Simkav added the bug Something isn't working label Mar 7, 2024
@Uzlopak
Copy link
Contributor

Uzlopak commented Mar 7, 2024

What CPU do you have?

@Simkav
Copy link
Author

Simkav commented Mar 7, 2024

What CPU do you have?

AMD Athlon(tm) II X3 455 Processor

@Uzlopak
Copy link
Contributor

Uzlopak commented Mar 7, 2024

@mcollina

We dropped in #2871 the non-simd version of wasm. Now @Simkav is reporting an issue, because his 14 year old processor does not work with wasm simd.

Should we revert #2871?
Should we say it is a breaking change and apply the idea of #2871 to next and with undici v7 we have to tell devs like Simkav, that they basically should get new hardware?

@mcollina
Copy link
Member

mcollina commented Mar 7, 2024

I think we would need to revert #2871, and possibly ship in v7.

@nodejs/build is there a minimum requirement for the CPU of Node.js? Can we expect simd to be there?

@targos
Copy link
Member

targos commented Mar 7, 2024

I guess it's the same issue as nodejs/citgm#1050 ?

@targos
Copy link
Member

targos commented Mar 7, 2024

power8 platform is under Tier 2 support: https://github.com/nodejs/node/blob/main/BUILDING.md#platform-list

@targos
Copy link
Member

targos commented Mar 7, 2024

/cc @richardlau

@richardlau
Copy link
Member

I think we would need to revert #2871, and possibly ship in v7.

@nodejs/build is there a minimum requirement for the CPU of Node.js? Can we expect simd to be there?

Generally there's been no minimum requirement -- in the past it's probably been more dictated by V8. I think Power is the only architecture we currently specify the version for. There's obviously a balancing act around the hardware we have access to in Build and what is obtainable.

@mhdawson
Copy link
Member

mhdawson commented Mar 7, 2024

To add to the discussion, another factor is which versions customer still use and are supported by distros, Power 8 is still in enough use that shipping distros support it and we want Node.js to support it.

@mhdawson
Copy link
Member

mhdawson commented Mar 7, 2024

In terms of requiring SIMD, would an option be to make that based on platform so that the decision can be made/influenced by those with insight into which cpu levels are in active use or not?

@mcollina
Copy link
Member

mcollina commented Mar 8, 2024

we had that option and we removed it thinking most CPU in use had SIMD, given than V8 had WASM support for SIMD. We were mistaken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants