Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

request body 'end' after destroy() asserts #66

Closed
ronag opened this issue May 5, 2020 · 0 comments · Fixed by #67
Closed

request body 'end' after destroy() asserts #66

ronag opened this issue May 5, 2020 · 0 comments · Fixed by #67
Assignees
@ronag
Labels
bug Something isn't working

Comments

@ronag
Copy link
Member

ronag commented May 5, 2020 •
edited
Loading

There is currently a race in body request handling when body.'end' is emitted after body.destroy(err) (this is a compat behavior of Readable and of legacy streams) which causes a failure on assert(this.socket) in the finished(body, ...) handler.
@ronag ronag added the bug Something isn't working label May 5, 2020
@ronag ronag self-assigned this May 5, 2020
@ronag ronag changed the title request body 'end' after destroy() request body 'end' after destroy() asserts May 5, 2020
ronag added a commit to nxtedition/undici that referenced this issue May 5, 2020
@ronag
fix: request body edge cases
d94df77 
Readable can emit 'end' after .destroy() as well
as legacy streams might not implement the whole
Readable contract properly. Try to handle these
edge cases better.

Fixes: nodejs#66
@ronag ronag mentioned this issue May 5, 2020
Merged
ronag added a commit to nxtedition/undici that referenced this issue May 5, 2020
@ronag
fix: request body edge cases
9c9d507 
Readable can emit 'end' after .destroy() as well
as legacy streams might not implement the whole
Readable contract properly. Try to handle these
edge cases better.

Fixes: nodejs#66
ronag added a commit to nxtedition/undici that referenced this issue May 5, 2020
@ronag
fix: request body edge cases
68e5e9e 
Readable can emit 'end' after .destroy() as well
as legacy streams might not implement the whole
Readable contract properly. Try to handle these
edge cases better.

Fixes: nodejs#66
ronag added a commit to nxtedition/undici that referenced this issue May 5, 2020
@ronag
fix: request body edge cases
1a80bee 
Readable can emit 'end' after .destroy() as well
as legacy streams might not implement the whole
Readable contract properly. Try to handle these
edge cases better.

Fixes: nodejs#66
ronag added a commit to nxtedition/undici that referenced this issue May 5, 2020
@ronag
fix: request body edge cases
5f1ecb5 
Readable can emit 'end' after .destroy() as well
as legacy streams might not implement the whole
Readable contract properly. Try to handle these
edge cases better.

Fixes: nodejs#66
ronag added a commit to nxtedition/undici that referenced this issue May 5, 2020
@ronag
fix: request body edge cases
1d6f169 
Readable can emit 'end' after .destroy() as well
as legacy streams might not implement the whole
Readable contract properly. Try to handle these
edge cases better.

Fixes: nodejs#66
ronag added a commit to nxtedition/undici that referenced this issue May 5, 2020
@ronag
fix: request body edge cases
ab522ca 
Readable can emit 'end' after .destroy() as well
as legacy streams might not implement the whole
Readable contract properly. Try to handle these
edge cases better.

Fixes: nodejs#66
ronag added a commit to nxtedition/undici that referenced this issue May 5, 2020
@ronag
fix: request body edge cases
8197016 
Readable can emit 'end' after .destroy() as well
as legacy streams might not implement the whole
Readable contract properly. Try to handle these
edge cases better.

Fixes: nodejs#66
ronag added a commit to nxtedition/undici that referenced this issue May 6, 2020
@ronag
fix: request body edge cases
ad22d6c 
Readable can emit 'end' after .destroy() as well
as legacy streams might not implement the whole
Readable contract properly. Try to handle these
edge cases better.

Fixes: nodejs#66
ronag added a commit to nxtedition/undici that referenced this issue May 6, 2020
@ronag
fix: request body edge cases
b4205a3 
Readable can emit 'end' after .destroy() as well
as legacy streams might not implement the whole
Readable contract properly. Try to handle these
edge cases better.

Fixes: nodejs#66
ronag added a commit to nxtedition/undici that referenced this issue May 6, 2020
@ronag
fix: request body edge cases
7b8f129 
Readable can emit 'end' after .destroy() as well
as legacy streams might not implement the whole
Readable contract properly. Try to handle these
edge cases better.

Fixes: nodejs#66
ronag added a commit to nxtedition/undici that referenced this issue May 6, 2020
@ronag
fix: request body edge cases
8503ef1 
Readable can emit 'end' after .destroy() as well
as legacy streams might not implement the whole
Readable contract properly. Try to handle these
edge cases better.

Fixes: nodejs#66
ronag added a commit to nxtedition/undici that referenced this issue May 6, 2020
@ronag
fix: request body edge cases
a8f285e 
Readable can emit 'end' after .destroy() as well
as legacy streams might not implement the whole
Readable contract properly. Try to handle these
edge cases better.

Fixes: nodejs#66
ronag added a commit to nxtedition/undici that referenced this issue May 6, 2020
@ronag
fix: request body edge cases
e5eddc1 
Readable can emit 'end' after .destroy() as well
as legacy streams might not implement the whole
Readable contract properly. Try to handle these
edge cases better.

Fixes: nodejs#66
ronag added a commit to nxtedition/undici that referenced this issue May 6, 2020
@ronag
fix: request body edge cases
0a80029 
Readable can emit 'end' after .destroy() as well
as legacy streams might not implement the whole
Readable contract properly. Try to handle these
edge cases better.

Fixes: nodejs#66
ronag added a commit to nxtedition/undici that referenced this issue May 6, 2020
@ronag
fix: request body edge cases
6d932fb 
Readable can emit 'end' after .destroy() as well
as legacy streams might not implement the whole
Readable contract properly. Try to handle these
edge cases better.

Fixes: nodejs#66
@ronag ronag closed this as completed in #67 May 6, 2020
ronag added a commit that referenced this issue May 6, 2020
@ronag
fix: request body edge cases
d8c16c8 
Readable can emit 'end' after .destroy() as well
as legacy streams might not implement the whole
Readable contract properly. Try to handle these
edge cases better.

Fixes: #66
@Simkav Simkav mentioned this issue Mar 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ronag ronag

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: request body edge cases nxtedition/undici
1 participant
@ronag