Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Contribution guide #2776

Closed
wants to merge 1 commit into from
Closed

Conversation

riderx
Copy link
Contributor

@riderx riderx commented Feb 18, 2024

This relates to tryting to contribute to the repo

I was trying to follow the guide for this PR:
#2775
And the first command to build was not working so i corrected the file with the right one

Rationale

Make easier to contribute to the repo following the guide

Changes

Only a MD file

Features

No

Bug Fixes

No

Breaking Changes and Deprecations

No

Status

@riderx
Copy link
Contributor Author

riderx commented Feb 18, 2024

I see this command exists but in the other repo, llhttp.
What doesn't make sense for the doc, since next step we need to copy wasm lib from undici.
Should both be run and my change is wrong ?

@riderx
Copy link
Contributor Author

riderx commented Feb 18, 2024

ok yes that was all command from llhttp

@riderx riderx closed this Feb 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant