This repository has been archived by the owner on Oct 7, 2020. It is now read-only.
doc: add summit meeting minutes #5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
aruneshchandra
approved these changes
Mar 7, 2017
|
@joshgav - This repo does seem like a better place to collect these notes. |
mhdawson
approved these changes
Mar 16, 2017
|
|
||
| Canvas perf regression is likely because there’s heavy usage of V8 APIs so much | ||
| more marshaling needed. Also first tried with C++ wrapper. No optimizations yet | ||
| either. |
There was a problem hiding this comment.
I suggest
Canvas perf regression is likely because the performance benchmark makes calls to canvas where the work done in the native method is very small. This means that any overhead, even the limited overhead added by N-API has a significant impact.
joshgav
added a commit
that referenced
this pull request
Mar 24, 2017
PR-URL: #5 Reviewed-By: Arunesh Chandra <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
|
landed in e86328b |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These notes are stored here: https://github.com/nodejs/abi-stable-node/tree/doc/meeting%20notes
But thought they might be better off here for reference. @aruneshchandra @mhdawson thoughts?