src: NODE_RELEASE should be node #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
santigimeno
force-pushed
the
santi/process_release
branch
from
3946ab3 to
04a1dc5
Compare
trevnorris
approved these changes
Nov 30, 2023
trevnorris
force-pushed
the
node-v20.x-nsolid-v5.x
branch
from
1a1236e to
b2c1bb3
Compare
So we remain compatible with Node.js. PR-URL: #36 Reviewed-by: Trevor Norris <[email protected]>
santigimeno
force-pushed
the
santi/process_release
branch
from
04a1dc5 to
21459cb
Compare
santigimeno
added a commit
that referenced
this pull request
Dec 6, 2023
So we remain compatible with Node.js. PR-URL: #36 Reviewed-by: Trevor Norris <[email protected]>
trevnorris
pushed a commit
that referenced
this pull request
Dec 7, 2023
So we remain compatible with Node.js. PR-URL: #36 Reviewed-by: Trevor Norris <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So we remain compatible with Node.js.
Example of code that was broken before this change:
https://github.com/google/dart_cli_pkg/blob/main/lib/src/js/js.dart#L47