Use the Octokit client for GitHub #246
Conversation
This replaces the old `github` package with the latest Octokit REST client which makes authentication work again. Additionally, the `NODIST_GITHUB_TOKEN` environment variable can now be used to supply a token for authenticating GitHub requests (and overcoming the unauthenticated request rate limit).
|
@marcelklehr any chance of getting this merged and released? |
|
@kraenhansen @fealebenpae I reviewed this and for the most part it looks good. The issue has been compiling a new release not merging the code. I do see this PR as an improvement over using a hacked library that is stale. When I get back to my dev PC I will work on merging these and compiling a release. |
|
@nullivex anything we can do to help? my org really could use the updated code. we're working around it currently. |
ghost
mentioned this pull request
|
is there a plan to cut a release with this fix in the near term? thanks |
|
There is a release candidate available. Check the release page. I could use some feedback on it. |
|
Thats great news. Unfortunately, I don't have an environment available to test this at the moment 🤔 |
|
Whenever you get a chance, I am hopeful we packaged in some fixes. |
Related to #244.
This replaces the old
githubpackage with the latest Octokit REST client which makes authentication work again.Additionally, the
NODIST_GITHUB_TOKENenvironment variable can now be used to supply a token for authenticating GitHub requests (and overcoming the unauthenticated request rate limit).I know that technically disabling auth altogether was an option, but updating the client seemed prudent to make sure the requests comply with GitHub API requirements.