Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): use known working node version for the installer #268

Merged
merged 2 commits into from
Dec 7, 2023

Conversation

Mairu
Copy link
Contributor

@Mairu Mairu commented Nov 26, 2023

There are errors when using node 21 with nodist -> #266 (comment)
Therefore fixing the node (major) version when building nodist is necessary.

Other changes:

  • fix npm links fallback
  • fix npm links handling for the installer too
  • use matching npm version for node version when building
  • GitHub workflows: allow triggering of installer creation without tagging
  • fix npm to use the correct version of node (previously fixed node version from the nodist installation directory was used -> could be checked with npm doctor

- fix npm links fallback
- fix npm links handling for installer too
- use matching npm version for node version when building
- GitHub workflows: allow triggering of installer creation without tagging
- refactor src folder structure to apply to golang-standards project-layout
@nullivex
Copy link
Member

Does this actually build the EXE? If so how did you get it to work in the CI environment?

@Mairu
Copy link
Contributor Author

Mairu commented Nov 26, 2023

Yes, the exe is built for tags, and with this MR I added the possibility to trigger the build manually. But this seems only to be possible in the main branch: https://docs.github.com/en/actions/using-workflows/manually-running-a-workflow

The pipeline configuration for building (and create the draft release) is in .github/workflows/release.yml.

@nullivex
Copy link
Member

I understand, but is there NSIS support with the needed plugin in the build environment?

@Mairu
Copy link
Contributor Author

Mairu commented Nov 26, 2023

I added a fetch_nsis_plugins.mjs file to download the necessary plugins, NSIS itself is part of the image.

@nullivex
Copy link
Member

Great work! That statisfies what I was curious about. I will add my review.

Copy link
Member

@nullivex nullivex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed these changes and asked about considerations I didn't understand when it came to building within the Github workspace. These all seem to be met. The abstraction of the code into lib/build.js is correct and acceptable.

The modifications to the Go code look straightforward and reflect the repository changes.

I see nothing wrong with these changes. I approve.

@nullivex nullivex merged commit 3d7483c into master Dec 7, 2023
1 check passed
@nullivex nullivex self-assigned this Dec 7, 2023
@Mairu Mairu deleted the fix-installer-versions branch December 8, 2023 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants