Skip to content

Commit

Permalink
fix: don't benchmark the "prove" command as it doesn't exist anymore (#…
Browse files Browse the repository at this point in the history
…5323)

# Description

## Problem

Related to #4754

## Summary

In order to improve execution performance we first need to benchmark
it... but, the current benchmark code also benchmarks the "prove"
command which doesn't exist anymore, so it can't run. This PR remove the
benchmark command related to the "prove" command.

I considered extracting the strings "prove" and "command" to constants,
so that if they are removed we would get a compile error, but... maybe
chances of a command getting removed are very low, so probably not worth
it.

## Additional Context

None.

## Documentation\*

Check one:
- [x] No documentation needed.
- [ ] Documentation included in this PR.
- [ ] **[For Experimental Features]** Documentation to be submitted in a
separate PR.

# PR Checklist\*

- [x] I have tested the changes locally.
- [x] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.
  • Loading branch information
asterite authored Jun 25, 2024
1 parent 8456185 commit 3bb3b03
Showing 1 changed file with 1 addition and 7 deletions.
8 changes: 1 addition & 7 deletions tooling/nargo_cli/benches/criterion.rs
Original file line number Diff line number Diff line change
Expand Up @@ -28,16 +28,10 @@ macro_rules! criterion_command {
};
}
criterion_command!(execution, "execute");
criterion_command!(prove, "prove");

criterion_group! {
name = execution_benches;
config = Criterion::default().sample_size(20).measurement_time(Duration::from_secs(20)).with_profiler(PProfProfiler::new(100, Output::Flamegraph(None)));
targets = criterion_selected_tests_execution
}
criterion_group! {
name = prove_benches;
config = Criterion::default().sample_size(10).measurement_time(Duration::from_secs(20)).with_profiler(PProfProfiler::new(100, Output::Flamegraph(None)));
targets = criterion_selected_tests_prove
}
criterion_main!(execution_benches, prove_benches);
criterion_main!(execution_benches);

0 comments on commit 3bb3b03

Please sign in to comment.