Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Brillig to be memory-only (no registers) #4158

Closed
Tracked by #4033
sirasistant opened this issue Jan 25, 2024 · 1 comment · Fixed by #4216
Closed
Tracked by #4033

Change Brillig to be memory-only (no registers) #4158

sirasistant opened this issue Jan 25, 2024 · 1 comment · Fixed by #4216
Assignees
@sirasistant
Labels
brillig Unconstrained functions / brillig IR enhancement New feature or request

Comments

@sirasistant
Copy link
Contributor

sirasistant commented Jan 25, 2024 •
edited
Loading

Brillig should only use memory. We can reserve a portion of memory for static addressing.
@sirasistant sirasistant mentioned this issue Jan 25, 2024
Closed
12 tasks
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Jan 25, 2024
@sirasistant sirasistant added the enhancement New feature or request label Jan 25, 2024
@sirasistant sirasistant self-assigned this Jan 25, 2024
@sirasistant sirasistant added the brillig Unconstrained functions / brillig IR label Jan 25, 2024
@sirasistant sirasistant mentioned this issue Jan 30, 2024
Merged
sirasistant added a commit to AztecProtocol/aztec-packages that referenced this issue Jan 30, 2024
@sirasistant
feat: Memory only brillig (#4215)
018177b 
This PR adds:
 - Memory only brillig noir-lang/noir#4158
 - Calldata and returndata noir-lang/noir#4159

We reserve some memory slots at the start of the memory space. We
reserve 1024 items for the stack frame, the calldata size and the
returndata size.
AztecBot pushed a commit to AztecProtocol/barretenberg that referenced this issue Jan 31, 2024
@sirasistant @AztecBot
feat: Memory only brillig (#4215)
e67281a 
This PR adds:
 - Memory only brillig noir-lang/noir#4158
 - Calldata and returndata noir-lang/noir#4159

We reserve some memory slots at the start of the memory space. We
reserve 1024 items for the stack frame, the calldata size and the
returndata size.
@sirasistant
Copy link
Contributor Author

Merged on aztec-packages, will come to the noir repo in #4216

@sirasistant sirasistant moved this from 📋 Backlog to 🏗 In progress in Noir Feb 1, 2024
@TomAFrench TomAFrench linked a pull request Feb 5, 2024 that will close this issue
feat: Sync commits from aztec-packages #4216
Merged
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Noir Feb 8, 2024
michaelelliot pushed a commit to Swoir/noir_rs that referenced this issue Feb 28, 2024
@sirasistant
feat: Memory only brillig (AztecProtocol#4215)
6dc0ff9 
This PR adds:
 - Memory only brillig noir-lang/noir#4158
 - Calldata and returndata noir-lang/noir#4159

We reserve some memory slots at the start of the memory space. We
reserve 1024 items for the stack frame, the calldata size and the
returndata size.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sirasistant sirasistant

Labels
brillig Unconstrained functions / brillig IR enhancement New feature or request
Projects
Noir
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Sync commits from aztec-packages noir-lang/noir
1 participant
@sirasistant