Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Hir -> Ast conversion #4796

Closed
Tracked by #4594
jfecher opened this issue Apr 12, 2024 · 0 comments · Fixed by #4788
Closed
Tracked by #4594

Add Hir -> Ast conversion #4796

jfecher opened this issue Apr 12, 2024 · 0 comments · Fixed by #4788
Labels
enhancement New feature or request

Comments

@jfecher
Copy link
Contributor

jfecher commented Apr 12, 2024

Problem

For metaprogramming we need to be able to go from the Hir back to the Ast to redo name resolution and type checking

Happy Case

We add a Hir -> Ast conversion pass to do this.

Project Impact

None

Impact Context

No response

Workaround

None

Workaround Description

No response

Additional Context

No response

Would you like to submit a PR for this Issue?

None

Support Needs

No response

@jfecher jfecher added the enhancement New feature or request label Apr 12, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Apr 12, 2024
github-merge-queue bot pushed a commit that referenced this issue Apr 12, 2024
# Description

## Problem\*

Resolves #4796

## Summary\*

 Adds a way to go from the Hir back to the Ast.
This conversion isn't exact and information is lost currently. Notably
many spans are lost and some constructs like `Type::TypeVariable` have
no equivalent in the Ast.

This also isn't expected to be idempotent. Different nodes may be
desugared, `let` statements may have explicit types added, etc.

## Additional Context

This is unused currently and can't be triggered from the current
compiler at all. I'm adding this PR now to split off required changes
for metaprogramming into smaller chunks.

## Documentation\*

Check one:
- [x] No documentation needed.
- [ ] Documentation included in this PR.
- [ ] **[For Experimental Features]** Documentation to be submitted in a
separate PR.

# PR Checklist\*

- [x] I have tested the changes locally.
- [x] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant