Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable support of u16 #4908

Closed
Savio-Sou opened this issue Apr 24, 2024 · 0 comments · Fixed by #4985
Closed

Enable support of u16 #4908

Savio-Sou opened this issue Apr 24, 2024 · 0 comments · Fixed by #4985
Assignees
Labels
enhancement New feature or request

Comments

@Savio-Sou
Copy link
Collaborator

Savio-Sou commented Apr 24, 2024

Problem

When #4162 was proposed and worked on, the AztecVM was uncertain about the support of u16 and the type was hence temporarily disabled.

Happy Case

With the uncertainty now resolved and support for u16 built in AztecVM, we should re-enable support of u16 for more consistent integer data types and better development flexibility.

Project Impact

None

Impact Context

No response

Workaround

None

Workaround Description

No response

Additional Context

Credit to @smanilov for flagging the gap.
#4162 (comment)

Would you like to submit a PR for this Issue?

None

Support Needs

No response

@Savio-Sou Savio-Sou added the enhancement New feature or request label Apr 24, 2024
@Savio-Sou Savio-Sou added this to Noir Apr 24, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Apr 24, 2024
github-merge-queue bot pushed a commit that referenced this issue May 7, 2024
# Description

## Problem\*

Resolves #4908

## Summary\*

Adds cases for `u16`. `i16` was right there so added at the same time.

## Additional Context



## Documentation\*

Check one:
- [ ] No documentation needed.
- [x] Documentation included in this PR.
- [ ] **[For Experimental Features]** Documentation to be submitted in a
separate PR.

# PR Checklist\*

- [x] I have tested the changes locally.
- [x] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.

---------

Co-authored-by: Tom French <[email protected]>
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants