feat!: Add semver checks for the compiler version in Nargo.toml

tooling/lsp/src/notifications/mod.rs

@@ -88,7 +88,7 @@ pub(super) fn on_did_save_text_document(
             return ControlFlow::Continue(());
         }
     };
-    let workspace = match resolve_workspace_from_toml(&toml_path, PackageSelection::All) {
+    let workspace = match resolve_workspace_from_toml(&toml_path, PackageSelection::All, None) {
         Ok(workspace) => workspace,
         Err(err) => {
             // If we found a manifest, but the workspace is invalid, we raise an error about it

tooling/lsp/src/requests/code_lens_request.rs

@@ -68,7 +68,7 @@ fn on_code_lens_request_inner(
         }
     };
     let workspace =
-        resolve_workspace_from_toml(&toml_path, PackageSelection::All).map_err(|err| {
+        resolve_workspace_from_toml(&toml_path, PackageSelection::All, None).map_err(|err| {
             // If we found a manifest, but the workspace is invalid, we raise an error about it
             ResponseError::new(ErrorCode::REQUEST_FAILED, err)
         })?;

tooling/lsp/src/requests/test_run.rs

@@ -38,12 +38,15 @@ fn on_test_run_request_inner(
     let crate_name = params.id.crate_name();
     let function_name = params.id.function_name();
 
-    let workspace =
-        resolve_workspace_from_toml(&toml_path, PackageSelection::Selected(crate_name.clone()))
-            .map_err(|err| {
-                // If we found a manifest, but the workspace is invalid, we raise an error about it
-                ResponseError::new(ErrorCode::REQUEST_FAILED, err)
-            })?;
+    let workspace = resolve_workspace_from_toml(
+        &toml_path,
+        PackageSelection::Selected(crate_name.clone()),
+        None,
+    )
+    .map_err(|err| {
+        // If we found a manifest, but the workspace is invalid, we raise an error about it
+        ResponseError::new(ErrorCode::REQUEST_FAILED, err)
+    })?;
 
     // Since we filtered on crate name, this should be the only item in the iterator
     match workspace.into_iter().next() {

tooling/lsp/src/requests/tests.rs

@@ -41,7 +41,7 @@ fn on_tests_request_inner(
     };
 
     let workspace =
-        resolve_workspace_from_toml(&toml_path, PackageSelection::All).map_err(|err| {
+        resolve_workspace_from_toml(&toml_path, PackageSelection::All, None).map_err(|err| {
             // If we found a manifest, but the workspace is invalid, we raise an error about it
             ResponseError::new(ErrorCode::REQUEST_FAILED, err)
         })?;

tooling/nargo/src/package.rs

@@ -43,6 +43,8 @@ impl Dependency {
 
 #[derive(Clone)]
 pub struct Package {
+    // A semver string which specifies the compiler version required to compile this package
+    pub compiler_required_version: Option<String>,
     pub root_dir: PathBuf,
     pub package_type: PackageType,
     pub entry_path: PathBuf,

tooling/nargo_cli/src/cli/check_cmd.rs

@@ -39,7 +39,7 @@ pub(crate) fn run(
     let default_selection =
         if args.workspace { PackageSelection::All } else { PackageSelection::DefaultOrAll };
     let selection = args.package.map_or(default_selection, PackageSelection::Selected);
-    let workspace = resolve_workspace_from_toml(&toml_path, selection)?;
+    let workspace = resolve_workspace_from_toml(&toml_path, selection, None)?;
 
     for package in &workspace {
         check_package(package, &args.compile_options)?;

tooling/nargo_cli/src/cli/codegen_verifier_cmd.rs

@@ -40,7 +40,7 @@ pub(crate) fn run(
     let default_selection =
         if args.workspace { PackageSelection::All } else { PackageSelection::DefaultOrAll };
     let selection = args.package.map_or(default_selection, PackageSelection::Selected);
-    let workspace = resolve_workspace_from_toml(&toml_path, selection)?;
+    let workspace = resolve_workspace_from_toml(&toml_path, selection, None)?;
 
     let (np_language, opcode_support) = backend.get_backend_info()?;
     for package in &workspace {

tooling/nargo_cli/src/cli/compile_cmd.rs

@@ -61,7 +61,12 @@ pub(crate) fn run(
     let default_selection =
         if args.workspace { PackageSelection::All } else { PackageSelection::DefaultOrAll };
     let selection = args.package.map_or(default_selection, PackageSelection::Selected);
-    let workspace = resolve_workspace_from_toml(&toml_path, selection)?;
+
+    let workspace = resolve_workspace_from_toml(
+        &toml_path,
+        selection,
+        Some(NOIR_ARTIFACT_VERSION_STRING.to_owned()),
+    )?;
     let circuit_dir = workspace.target_directory_path();
 
     let (binary_packages, contract_packages): (Vec<_>, Vec<_>) = workspace

tooling/nargo_cli/src/cli/debug_cmd.rs

@@ -41,7 +41,7 @@ pub(crate) fn run(
 ) -> Result<(), CliError> {
     let toml_path = get_package_manifest(&config.program_dir)?;
     let selection = args.package.map_or(PackageSelection::DefaultOrAll, PackageSelection::Selected);
-    let workspace = resolve_workspace_from_toml(&toml_path, selection)?;
+    let workspace = resolve_workspace_from_toml(&toml_path, selection, None)?;
     let target_dir = &workspace.target_directory_path();
     let (np_language, opcode_support) = backend.get_backend_info()?;
 

tooling/nargo_cli/src/cli/execute_cmd.rs

@@ -48,7 +48,7 @@ pub(crate) fn run(
     let default_selection =
         if args.workspace { PackageSelection::All } else { PackageSelection::DefaultOrAll };
     let selection = args.package.map_or(default_selection, PackageSelection::Selected);
-    let workspace = resolve_workspace_from_toml(&toml_path, selection)?;
+    let workspace = resolve_workspace_from_toml(&toml_path, selection, None)?;
     let target_dir = &workspace.target_directory_path();
 
     let (np_language, opcode_support) = backend.get_backend_info()?;

tooling/nargo_cli/src/cli/fmt_cmd.rs

@@ -15,7 +15,7 @@ pub(crate) struct FormatCommand {}
 
 pub(crate) fn run(_args: FormatCommand, config: NargoConfig) -> Result<(), CliError> {
     let toml_path = get_package_manifest(&config.program_dir)?;
-    let workspace = resolve_workspace_from_toml(&toml_path, PackageSelection::All)?;
+    let workspace = resolve_workspace_from_toml(&toml_path, PackageSelection::All, None)?;
 
     let config = nargo_fmt::Config::read(&config.program_dir)
         .map_err(|err| CliError::Generic(err.to_string()))?;

tooling/nargo_cli/src/cli/info_cmd.rs

@@ -47,7 +47,7 @@ pub(crate) fn run(
     let default_selection =
         if args.workspace { PackageSelection::All } else { PackageSelection::DefaultOrAll };
     let selection = args.package.map_or(default_selection, PackageSelection::Selected);
-    let workspace = resolve_workspace_from_toml(&toml_path, selection)?;
+    let workspace = resolve_workspace_from_toml(&toml_path, selection, None)?;
 
     let (binary_packages, contract_packages): (Vec<_>, Vec<_>) = workspace
         .into_iter()

tooling/nargo_cli/src/cli/prove_cmd.rs

@@ -51,7 +51,7 @@ pub(crate) fn run(
     let default_selection =
         if args.workspace { PackageSelection::All } else { PackageSelection::DefaultOrAll };
     let selection = args.package.map_or(default_selection, PackageSelection::Selected);
-    let workspace = resolve_workspace_from_toml(&toml_path, selection)?;
+    let workspace = resolve_workspace_from_toml(&toml_path, selection, None)?;
 
     let (np_language, opcode_support) = backend.get_backend_info()?;
     for package in &workspace {

tooling/nargo_cli/src/cli/test_cmd.rs

@@ -51,7 +51,7 @@ pub(crate) fn run(
     let default_selection =
         if args.workspace { PackageSelection::All } else { PackageSelection::DefaultOrAll };
     let selection = args.package.map_or(default_selection, PackageSelection::Selected);
-    let workspace = resolve_workspace_from_toml(&toml_path, selection)?;
+    let workspace = resolve_workspace_from_toml(&toml_path, selection, None)?;
 
     let pattern = match &args.test_name {
         Some(name) => {

tooling/nargo_cli/src/cli/verify_cmd.rs

@@ -42,7 +42,7 @@ pub(crate) fn run(
     let default_selection =
         if args.workspace { PackageSelection::All } else { PackageSelection::DefaultOrAll };
     let selection = args.package.map_or(default_selection, PackageSelection::Selected);
-    let workspace = resolve_workspace_from_toml(&toml_path, selection)?;
+    let workspace = resolve_workspace_from_toml(&toml_path, selection, None)?;
 
     let (np_language, opcode_support) = backend.get_backend_info()?;
     for package in &workspace {

tooling/nargo_toml/Cargo.toml

@@ -17,5 +17,6 @@ serde.workspace = true
 thiserror.workspace = true
 toml.workspace = true
 url.workspace = true
+semver = "1.0.20"
 
 [dev-dependencies]

tooling/nargo_toml/src/errors.rs

@@ -4,7 +4,8 @@ use nargo::package::PackageType;
 use noirc_frontend::graph::CrateName;
 use thiserror::Error;
 
-/// Errors covering situations where a package is either missing or malformed.
+/// Errors covering situations where a package is either missing, malformed or does not pass semver
+/// validation checks.
 #[derive(Debug, Error)]
 pub enum ManifestError {
     /// Package doesn't have a manifest file
@@ -65,4 +66,19 @@ pub enum ManifestError {
 
     #[error("No common ancestor between {root} and {current}")]
     NoCommonAncestor { root: PathBuf, current: PathBuf },
+
+    #[error(transparent)]
+    SemverError(SemverError),
+}
+
+#[derive(Error, Debug, PartialEq, Eq, Clone)]
+pub enum SemverError {
+    #[error("Incompatible compiler version in package {package_name}. Required version is {required_compiler_version} but the compiler version is {compiler_version_found}")]
+    IncompatibleVersion {
+        package_name: CrateName,
+        required_compiler_version: String,
+        compiler_version_found: String,
+    },
+    #[error("Could not parse the required compiler version for package {package_name} in Nargo.toml. Error: {error}")]
+    CouldNotParseRequiredVersion { package_name: String, error: String },
 }

tooling/nargo_toml/src/lib.rs

@@ -18,6 +18,7 @@ use serde::Deserialize;
 
 mod errors;
 mod git;
+mod semver;
 
 pub use errors::ManifestError;
 use git::clone_git_repo;
@@ -163,6 +164,7 @@ impl PackageConfig {
         };
 
         Ok(Package {
+            compiler_required_version: self.package.compiler_version.clone(),
             root_dir: root_dir.to_path_buf(),
             entry_path,
             package_type,
@@ -228,7 +230,7 @@ struct PackageMetadata {
     entry: Option<PathBuf>,
     description: Option<String>,
     authors: Option<Vec<String>>,
-    // If not compiler version is supplied, the latest is used
+    // If no compiler version is supplied, the latest is used
     // For now, we state that all packages must be compiled under the same
     // compiler version.
     // We also state that ACIR and the compiler will upgrade in lockstep.
@@ -391,10 +393,14 @@ pub enum PackageSelection {
 pub fn resolve_workspace_from_toml(
     toml_path: &Path,
     package_selection: PackageSelection,
+    current_compiler_version: Option<String>,
 ) -> Result<Workspace, ManifestError> {
     let nargo_toml = read_toml(toml_path)?;
-
-    toml_to_workspace(nargo_toml, package_selection)
+    let workspace = toml_to_workspace(nargo_toml, package_selection)?;
+    if let Some(current_compiler_version) = current_compiler_version {
+        semver::semver_check_workspace(workspace.clone(), current_compiler_version)?;
+    }
+    Ok(workspace)
 }
 
 #[test]