fix: pub is required on return for entry points

compiler/noirc_frontend/src/hir/resolution/resolver.rs

@@ -95,7 +95,7 @@
 
     /// True if the current module is a contract.
     /// This is usually determined by self.path_resolver.module_id(), but it can
     /// be overriden for impls. Impls are an odd case since the methods within resolve
     /// as if they're in the parent module, but should be placed in a child module.
     /// Since they should be within a child module, in_contract is manually set to false
     /// for these so we can still resolve them in the parent module without them being in a contract.
@@ -790,8 +790,8 @@
             });
         }
 
-        // 'pub_allowed' also implies 'pub' is required on return types
-        if self.pub_allowed(func)
+        // 'pub' is required on return types for entry point functions
+        if self.is_entry_point_function(func)
             && return_type.as_ref() != &Type::Unit
             && func.def.return_visibility != Visibility::Public
         {

test_programs/compile_success_contract/simple_contract/src/main.nr

@@ -11,4 +11,9 @@ contract Foo {
     open internal fn skibbidy(x: Field) -> pub Field {
         x * 5
     }
+    // Regression for issue #3344
+    #[contract_library_method]
+    fn foo(x : u8) -> u8 {
+        x
+    }
 }