Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Dynamic index for slice insert and remove #3624

Merged
merged 4 commits into from
Nov 30, 2023

Conversation

vezenovm
Copy link
Contributor

Description

Problem*

Resolves #2462

Summary*

This PR simply builds upon #3617 by including some tests that use a dynamic index on SliceInsert and SliceRemove.

Additional Context

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [Exceptional Case] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

Copy link
Contributor

github-actions bot commented Nov 28, 2023

Changes to circuit sizes

Generated at commit: c4d3bcb2a9d203c22d64a8f53a95b02c07502806, compared to commit: 7baaa2e12bd5ac0238cd4ab4e4b41ac557adefe0

🧾 Summary (10% most significant diffs)

Program ACIR opcodes (+/-) % Circuit size (+/-) %
slice_struct_field +6,798 ❌ +24.20% +15,494 ❌ +16.87%
slice_dynamic_index +25 ❌ +0.88% +32 ❌ +0.28%

Full diff report 👇
Program ACIR opcodes (+/-) % Circuit size (+/-) %
slice_struct_field 34,892 (+6,798) +24.20% 107,356 (+15,494) +16.87%
slice_dynamic_index 2,860 (+25) +0.88% 11,514 (+32) +0.28%

@vezenovm
Copy link
Contributor Author

@jfecher This PR builds upon #3617 so I was thinking to merge this PR once the parent is in master. Although this is mainly test changes so if you are fine with it I can squash into the parent whenever.

@TomAFrench
Copy link
Member

If it's just adding tests for a feature added in the other PR I think we can merge it into there.

@vezenovm vezenovm merged commit 3ab0504 into mv/dyn-nested-slice-builtin Nov 30, 2023
33 checks passed
@vezenovm vezenovm deleted the mv/dyn-idx-insert-remove branch November 30, 2023 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants