-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Resolve oracle calls via JSON-RPC #3902
Conversation
deny.toml is failing because of CC0 license -- we already rely on a CC0 license, so I don't think this is a blocker -- see note in deny.toml as to why we conservatively deny CC0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - was cargo update ran on this branch? most changes are coming from the cargo.lock
Nope, but i'll reset cargo lock to master and run cargo build again just to make sure |
* master: chore: Optimize goto_definitions for workspace case (#3914) chore: Update index.md (#3911) chore: Update index.md (#3910) chore: Update how-to-recursion.md (#3912) feat: Resolve oracle calls via JSON-RPC (#3902) chore: Update explainer-recursion.md (#3906) chore: remove unnecessary dependency (#3901) chore: improve package.json metadata (#3900) feat: prefer `AcirContext`-native methods for performing logic operations (#3898) feat: optimize logic gate ACIR-gen (#3897) fix: allow abi encoding tuples from JS (#3894) chore: error on cspell issues in docs (#3886)
* master: (48 commits) chore: fix broken links (#3935) chore: updated ACIR documentation and other docs (#3932) chore: rename "syntax" chapter in docs to "concepts" (#3934) fix: checks for cyclic dependencies (#3699) fix(debugger): crash when stepping through locations spanning multiple lines (#3920) chore: abstract away subtractions from `OR` implementation (#3923) chore: fix `should_fail_mismatch` test to use correct pedersen return type (#3927) fix: prevent `Instruction::Constrain`s for non-primitive types (#3916) feat: remove unnecessary predicate from `Lt` instruction (#3922) feat: simplify multiplications by `0` or `1` in ACIR gen (#3924) chore: bump dependency versions (#3925) chore: Update CONTRIBUTING.md (#3921) chore: Optimize goto_definitions for workspace case (#3914) chore: Update index.md (#3911) chore: Update index.md (#3910) chore: Update how-to-recursion.md (#3912) feat: Resolve oracle calls via JSON-RPC (#3902) chore: Update explainer-recursion.md (#3906) chore: remove unnecessary dependency (#3901) chore: improve package.json metadata (#3900) ...
Description
This adds a JSON-RPC client to the DefaultForeignCallExecutor. This allows it to solve unknown oracle calls. The URL to the foreign call executor is an optional argument to nargo execute, nargo test and nargo prove.
Problem*
Resolves #1052
Summary*
Additional Context
An example echo server in typescript
And the corresponding main.nr
Documentation*
Check one:
(We can document this when we evaluate if this solution is enough)
PR Checklist*
cargo fmt
on default settings.