Fix error compiling the noirc_frontend crate
#404
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes noir-lang#403. No compilation features were provided so the user wasn't able to compile this crate successfully. Now the user could compile with the bn254 feature or the bls12_381 feature.
jfecher
requested changes
Nov 1, 2022
5 tasks
|
Closing this because not following this strategy was intentional because a lot of curves and fields are expected to be added in the future. |
signorecello
added a commit
that referenced
this pull request
Oct 17, 2023
signorecello
added a commit
that referenced
this pull request
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue(s)
Resolves #403
Description
No compilation features were provided so the user wasn't able to compile this crate successfully.
Summary of changes
Added two compilation features (
bn254andbls12_381). Now the user could compile with thebn254feature or thebls12_381feature.Checklist
cargo fmtwith default settings.Additional context
This fix solves the compilation impossibility. I don't know if the idea is to have both features available for this crate. Let me know if something is off.