Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix Search Input Visibility in Dark Mode #4317

Merged
merged 2 commits into from
Feb 10, 2024
Merged

chore: Fix Search Input Visibility in Dark Mode #4317

merged 2 commits into from
Feb 10, 2024

Conversation

joaolago1113
Copy link
Contributor

Summary

This pull request addresses an issue with the search input box on the Noir documentation site when in dark mode. The text within the search box is illegible due to the white background color, which conflicts with the white text color.

Problem Description

In dark mode, the background color of the search input box remains white, while the text color is also white, rendering the text invisible to users. This creates a poor user experience as it prevents users from seeing what they are typing into the search box.

Solution

To fix this issue, the background color of the search input box has been changed to transparent, allowing for the text to be visible in both light and dark modes.

Visual Evidence of Issue

Desktop Dark Mode

Input State Screenshot
Text Entered, Barely Visible
Text barely visible in search box on desktop dark mode

Mobile Dark Mode

Input State Screenshot
Text Entered, Barely Visible
Text barely visible in search box on mobile dark mode

Visual Comparison

Mode Before Change After Change
Dark - Desktop
Before Desktop Dark
After Desktop Dark
Light - Desktop
Before Desktop Light
After Desktop Light
Dark - Mobile
Before Mobile Dark
After Mobile Dark
Light - Mobile
Before Mobile Light
After Mobile Light

Files Changed

  • docs/src/css/custom.css: Added styles to override the default background color of the #docsearch-input element.

Testing

The changes have been tested across various browsers and devices to ensure compatibility and that the search input box text is now clearly visible in both light and dark modes.

@TomAFrench TomAFrench changed the title fix: Fix Search Input Visibility in Dark Mode chore: Fix Search Input Visibility in Dark Mode Feb 9, 2024
@TomAFrench
Copy link
Member

Please don't update the branch unless there's a merge conflict (which is very unlikely to happen on the docs). It just chews up CI time for no reason.

Copy link
Contributor

@jfecher jfecher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jfecher jfecher requested a review from a team February 9, 2024 17:13
@jfecher
Copy link
Contributor

jfecher commented Feb 9, 2024

CC @noir-lang/developerrelations

Copy link
Contributor

@critesjosh critesjosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@TomAFrench TomAFrench enabled auto-merge February 10, 2024 14:36
@TomAFrench TomAFrench disabled auto-merge February 10, 2024 14:36
@TomAFrench TomAFrench merged commit b41ce8b into noir-lang:master Feb 10, 2024
31 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants