Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: test PR merging #6585 and #6577 #6607

Closed
wants to merge 23 commits into from
Closed

chore: test PR merging #6585 and #6577 #6607

wants to merge 23 commits into from

Conversation

jfecher
Copy link
Contributor

@jfecher jfecher commented Nov 22, 2024

Description

Problem*

Resolves

Summary*

Merges #6585 and #6577 to see opcode count differences.

Additional Context

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@jfecher jfecher changed the title Chore: test PR merging #6585 and #6577 chore: test PR merging #6585 and #6577 Nov 22, 2024
Copy link
Contributor

github-actions bot commented Nov 22, 2024

Changes to Brillig bytecode sizes

Generated at commit: f60037373ed4b8f3c0e0b56ed23b5498f70337d7, compared to commit: 920077da2d75493328c12d99b5684356c1ea1c4c

🧾 Summary (10% most significant diffs)

Program Brillig opcodes (+/-) %
reference_counts +756 ❌ +222.35%
check_large_field_bits +486 ❌ +166.44%
slice_regex +3,363 ❌ +156.49%
cast_and_shift_global +107 ❌ +142.67%
brillig_nested_arrays +229 ❌ +133.92%
debug_logs +4,856 ❌ +96.98%
bigint +1,894 ❌ +95.61%
strings +661 ❌ +75.03%

Full diff report 👇
Program Brillig opcodes (+/-) %
reference_counts 1,096 (+756) +222.35%
check_large_field_bits 778 (+486) +166.44%
slice_regex 5,512 (+3,363) +156.49%
cast_and_shift_global 182 (+107) +142.67%
brillig_nested_arrays 400 (+229) +133.92%
debug_logs 9,863 (+4,856) +96.98%
bigint 3,875 (+1,894) +95.61%
strings 1,542 (+661) +75.03%
slices 2,276 (+542) +31.26%
hashmap 25,089 (+5,274) +26.62%
uhashmap 16,577 (+3,391) +25.72%
array_to_slice 853 (+174) +25.63%
keccak256 2,187 (+403) +22.59%
nested_array_in_slice 1,353 (+248) +22.44%
nested_array_dynamic 2,555 (+407) +18.95%
regression_struct_array_conditional 619 (+88) +16.57%
side_effects_constrain_array 150 (+21) +16.28%
brillig_rc_regression_6123 208 (+25) +13.66%
fold_2_to_17 639 (+68) +11.91%
sha256 2,438 (+231) +10.47%
sha256_var_padding_regression 5,233 (+482) +10.15%
sha256_var_size_regression 1,866 (+165) +9.70%
fold_complex_outputs 526 (+46) +9.58%
nested_dyn_array_regression_5782 182 (+15) +8.98%
modulus 1,914 (+152) +8.63%
7_function 578 (+44) +8.24%
6 1,199 (+86) +7.73%
sha2_byte 2,925 (+205) +7.54%
merkle_insert 821 (+57) +7.46%
simple_shield 929 (+64) +7.40%
schnorr 1,518 (+104) +7.36%
conditional_regression_short_circuit 1,272 (+86) +7.25%
no_predicates_numeric_generic_poseidon 800 (+52) +6.95%
fold_numeric_generic_poseidon 800 (+52) +6.95%
u128 2,930 (+174) +6.31%
aes128_encrypt 551 (+31) +5.96%
regression_5252 4,794 (+269) +5.94%
sha256_var_witness_const_regression 1,301 (+72) +5.86%
sha256_regression 6,904 (+381) +5.84%
poseidonsponge_x5_254 4,406 (+243) +5.84%
struct_inputs 273 (+15) +5.81%
pedersen_check 578 (+26) +4.71%
brillig_pedersen 578 (+26) +4.71%
slice_loop 269 (+12) +4.67%
bench_2_to_17 348 (+15) +4.50%
poseidon2 355 (+15) +4.41%
poseidon_bn254_hash_width_3 5,564 (+234) +4.39%
poseidon_bn254_hash 5,564 (+234) +4.39%
array_sort 304 (+12) +4.11%
brillig_oracle 369 (+14) +3.94%
array_dynamic_nested_blackbox_input 897 (+33) +3.82%
regression_4449 744 (+20) +2.76%
wildcard_type 297 (+7) +2.41%
sha256_brillig_performance_regression 1,661 (+31) +1.90%
ram_blowup_regression 968 (+17) +1.79%
higher_order_functions 676 (+11) +1.65%
brillig_cow_regression 2,166 (+31) +1.45%
to_be_bytes 211 (+3) +1.44%
regression_capacity_tracker 237 (+3) +1.28%
slice_dynamic_index 2,560 (+27) +1.07%
brillig_cow 371 (+3) +0.82%
ecdsa_secp256k1 901 (+6) +0.67%
array_dynamic_blackbox_input 1,025 (+6) +0.59%
conditional_1 1,181 (+6) +0.51%
regression 944 (+3) +0.32%

Copy link
Contributor

github-actions bot commented Nov 22, 2024

Changes to circuit sizes

Generated at commit: f60037373ed4b8f3c0e0b56ed23b5498f70337d7, compared to commit: 920077da2d75493328c12d99b5684356c1ea1c4c

🧾 Summary (10% most significant diffs)

Program ACIR opcodes (+/-) % Circuit size (+/-) %
nested_array_dynamic +161 ❌ +4.91% +283 ❌ +2.24%
array_dynamic_nested_blackbox_input +6 ❌ +2.43% +17 ❌ +0.23%

Full diff report 👇
Program ACIR opcodes (+/-) % Circuit size (+/-) %
nested_array_dynamic 3,442 (+161) +4.91% 12,933 (+283) +2.24%
array_dynamic_nested_blackbox_input 253 (+6) +2.43% 7,326 (+17) +0.23%
reference_counts 0 (-3) -100.00% 16 (0) 0.00%

@jfecher
Copy link
Contributor Author

jfecher commented Nov 22, 2024

Curious that opcode & constraint count diffs are the same as in #6585, but unlike that PR the opcodes executed is unchanged from master?

Maybe its because the other PR has more commits, and if opcodes executed becomes unchanged then the comment isn't updated?

Copy link
Contributor

github-actions bot commented Dec 2, 2024

Peak Memory Sample

Program Peak Memory
keccak256 84.01M
workspace 122.04M
regression_4709 348.12M

@jfecher jfecher closed this Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants