Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add credentials to registry resource #68

Merged
merged 1 commit into from
Sep 26, 2020

Conversation

joshuastern
Copy link
Contributor

@joshuastern joshuastern commented Sep 21, 2020

Description

We use external registries that require credentials. This PR is adding access_key, access_secret and credential_type to the harbor_registry resource so that such registries can be managed by terraform.

Acceptance tests

  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Documentation

  • Have you create or updated the provider documentation at ./documentation/provider_doc?
    • If new resources or datasource documentation happen, did you add this to the mkdocs.yml configuration?

References

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@boring-cyborg boring-cyborg bot added the documentations Update documentation label Sep 21, 2020
@nolte nolte merged commit 3385a42 into nolte:develop Sep 26, 2020
@joshuastern joshuastern deleted the registry-credentials branch September 27, 2020 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentations Update documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants