Feature: 事件响应器的 __repr__ 方法添加 rule 信息
#2295
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2295 +/- ##
=======================================
Coverage 89.92% 89.92%
=======================================
Files 46 46
Lines 3345 3345
=======================================
Hits 3008 3008
Misses 337 337
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
🚀 Deployed on https://deploy-preview-2295--nonebot2.netlify.app |
|
之前就是你们觉得日志太长才把这些东西删掉的 |
|
rule信息展示出来会很长，可以考虑展示 lineno |
或许可以考虑只在 debug 日志中展示详细信息？ |
|
当初就是说的debug日志太长了啥都要找 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
目前
__repr__方法展示的信息区分度不足，同一插件内的多个事件响应器无法区分。通过添加 rule 信息，能够很好的区分不同事件响应器。