Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bucket notifications - connect mount should be unique #1514

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

alphaprinz
Copy link
Contributor

@alphaprinz alphaprinz commented Jan 27, 2025

Explain the changes

  1. Change mount path of connection secret to include name of secret.

Issues: Fixed #xxx / Gap #xxx

  1. Allow multiple secrets to be configures in NooBaa crd spec under bucketNotifications.connections.
    https://issues.redhat.com/browse/DFBUGS-1481

Testing Instructions:

  1. Configure two connections in bucketNotifications.connections.
  • Doc added/updated
  • Tests added

@alphaprinz alphaprinz merged commit 63f3156 into noobaa:master Jan 28, 2025
14 checks passed
alphaprinz added a commit to alphaprinz/noobaa-operator that referenced this pull request Jan 28, 2025
alphaprinz added a commit to alphaprinz/noobaa-operator that referenced this pull request Jan 29, 2025
alphaprinz added a commit to alphaprinz/noobaa-operator that referenced this pull request Jan 29, 2025
alphaprinz added a commit to alphaprinz/noobaa-operator that referenced this pull request Jan 29, 2025
alphaprinz added a commit to alphaprinz/noobaa-operator that referenced this pull request Jan 29, 2025
alphaprinz added a commit to alphaprinz/noobaa-operator that referenced this pull request Jan 29, 2025
nimrod-becker pushed a commit that referenced this pull request Jan 29, 2025
…nique (#1514) (#1515)

* bucket notifications - connect mount should be unique (#1514)

Signed-off-by: Amit Prinz Setter <[email protected]>

* Also install setuptools

Without setuptools, running operator-courier fails with:

```
Traceback (most recent call last):
  File "/Users/zregvart/work/croz/noobaa/noobaa-operator/build/_output/venv/bin/operator-courier", line 5, in <module>
    from operatorcourier.cli import main
  File "/Users/zregvart/work/croz/noobaa/noobaa-operator/build/_output/venv/lib/python3.13/site-packages/operatorcourier/cli.py", line 2, in <module>
    import pkg_resources
ModuleNotFoundError: No module named 'pkg_resources'
make: *** [gen-olm] Error 1
```

Signed-off-by: Zoran Regvart <[email protected]>

---------

Signed-off-by: Amit Prinz Setter <[email protected]>
Signed-off-by: Zoran Regvart <[email protected]>
Co-authored-by: Zoran Regvart <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants