Skip to content
This repository has been archived by the owner on Oct 1, 2018. It is now read-only.

Implement chcp_beforeAssetsInstalledOnExternalStorage event #105

Closed
kenvunz opened this issue Feb 23, 2016 · 6 comments
Closed

Implement chcp_beforeAssetsInstalledOnExternalStorage event #105

kenvunz opened this issue Feb 23, 2016 · 6 comments

Comments

@kenvunz
Copy link
Contributor

kenvunz commented Feb 23, 2016

Hi there,

The process of copying the www folder over external storage can take a while on old Android devices. Just wonder if we could have a chcp_beforeAssetsInstalledOnExternalStorage event implemented just so allowing the app to display some sort of message saying "please patient..." while it's happening?

@toostn
Copy link
Contributor

toostn commented Feb 23, 2016

This is what I implemented as a PR for issue #100. I think it was merged for next release.

@kenvunz
Copy link
Contributor Author

kenvunz commented Feb 24, 2016

ah awesome! so it does include the scenario when the plugin is copying assets to external storage as well?

@toostn
Copy link
Contributor

toostn commented Feb 24, 2016

I'm not completely sure about the different stages of updating, but I use the event to show the splash screen while the plugin copies the files and restarts the webview, and for that it works well. Since I only update the js on resume/launch, it just appears to the user as if the launch takes a little longer than normal.

Note that in order to avoid the flickering as the webview reloads your js/html, you need some kind of cordova plugin to show above the webview, like the corodova-plugin-splashscreen does.

@nikDemyankov
Copy link
Member

No, @toostn PR doesn't cover assets installation scenario. It's a different event. But yes, chcp_beforeAssetsInstalledOnExternalStorage can be added.

@nikDemyankov nikDemyankov added this to the v1.3.0 milestone Feb 25, 2016
@kenvunz
Copy link
Contributor Author

kenvunz commented Feb 25, 2016

👍 legend!

@nikDemyankov
Copy link
Member

Released in v1.3.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants