New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cider evaluation result looks unreadable in terminal #70

Closed

fmnoise opened this issue Apr 6, 2019 · 1 comment · Fixed by #71

Labels

context-package-support context-syntax scope-compatibility scope-ux status-in-review type-feature

Milestone

Contributor

fmnoise commented Apr 6, 2019 •

edited

Loading

Cider evaluation result is not readable in iterm2, nord-iterm2 installed

fmnoise mentioned this issue

Fix cider evaluation result in terminal #71

Merged

arcticicestudio added context-package-support context-syntax scope-compatibility scope-ux status-in-review type-feature labels

arcticicestudio added this to the 0.5.0 milestone

Contributor

arcticicestudio commented Jan 6, 2020

Reviewed #71 and added change suggestions.

arcticicestudio assigned fmnoise

arcticicestudio closed this as completed in #71

arcticicestudio pushed a commit that referenced this issue


          Fix cider evaluation result in terminal (#71)

995d842

When running the "Cider" package [1] in Emacs GUI mode through iTerm2 on
macOS, the background and font color in the evaluation result overlay
was the same (or very similar) color so it became unreadable.
Probably that's because of defined `cider-result-overlay-face` face [2]
and a difference in the rendering engine of iTerm2.

To prevent this problem, the background color has been removed.

[1]: https://github.com/clojure-emacs/cider
[2]: https://github.com/clojure-emacs/cider/blob/f6ac1594eb20b0d3b9f9b7601e3d2708346dc0bb/cider-overlays.el#L35

Closes GH-70

arcticicestudio unassigned fmnoise

arcticicestudio pushed a commit that referenced this issue


          Fix cider evaluation result in terminal (#71)

51ce3d3

When running the "Cider" package [1] in Emacs GUI mode through iTerm2 on
macOS, the background and font color in the evaluation result overlay
was the same (or very similar) color so it became unreadable.
Probably that's because of defined `cider-result-overlay-face` face [2]
and a difference in the rendering engine of iTerm2.

To prevent this problem, the background color has been removed.

[1]: https://github.com/clojure-emacs/cider
[2]: https://github.com/clojure-emacs/cider/blob/f6ac1594eb20b0d3b9f9b7601e3d2708346dc0bb/cider-overlays.el#L35

Closes GH-70

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment