Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

show-paren-match face not themed in Emacs 26 #75

Closed
janusvm opened this issue May 10, 2019 · 2 comments · Fixed by #89
Closed

show-paren-match face not themed in Emacs 26 #75

janusvm opened this issue May 10, 2019 · 2 comments · Fixed by #89
Labels
context-syntax scope-compatibility status-accepted type-feature
Milestone
0.5.0

Comments

@janusvm
Copy link

janusvm commented May 10, 2019

Came across this while adapting my config for Emacs 26.2 coming from 25.3

It seems as if something changed between Emacs versions 25 and 26 wrt. how the names of faces are parsed, which causes the following lines to work fine in Emacs 25, but not 26:

https://github.com/arcticicestudio/nord-emacs/blob/9ed7b9c2d1bb68ae86d06f97d215d2883e4ff0d2/nord-theme.el#L273-L274

seemingly due to the names of the faces not actually having the -face suffix.

The same is the case for running M-x customize-face RET show-paren-match-face RET - works in 25, not 26, even though the face is really called just show-paren-match in both.

In my local nord-theme.el on my Emacs 26 installation, I tried changing show-paren-match-face to just show-paren-match (same for -mismatch), and then it worked. I'm not sure if these are the only faces affected by this.
@arcticicestudio arcticicestudio self-assigned this May 11, 2019
@janusvm
Copy link
Author

janusvm commented Jun 19, 2019

After digging around a bit, I found that show-paren-match-face and show-paren-mismatch-face were declared as obsolete face aliases for show-paren-match and show-paren-mismatch, respectively, since version 22.1, and they were then completely removed somewhere in version 25 (commit c430f7e23f on the git repo).

I think this means that dropping the -face suffixes would fix the issue for newer versions, but introduce it for versions older than 22.1.

@arcticicestudio
Copy link
Contributor

arcticicestudio commented Jun 19, 2019 •
edited
Loading

Hi @janusvm 👋, thanks for your contribution 👍
Good catch, I've also noticed the defined styles of matching braces changed or respectively aren't respected at all. Thanks a lot for researching the commits and docs!
I guess simply adding the new key names should be fine, there's no need to rename or remove the deprecated ones since Emacs will decide which to use based on the version. This means both versions <22.1 and >=22.1 are supported 😄

GitHub Mirror PR: emacs-mirror/emacs@c430f7e

@arcticicestudio arcticicestudio added this to the Next milestone Jun 19, 2019
arcticicestudio added a commit that referenced this issue Jan 5, 2020
@arcticicestudio
Migrate away from deprecated show-paren-X-face faces
c6aeddb 
The `show-paren-match-face` and `show-paren-mismatch-face` face are
deprecated since Emacs version 22.1 [1,2] and were removed in Emacs 25.
To provide compatibilty to later EMacs version, the new
`show-paren-match` and `show-paren-mismatch` faces have been added.

The deprecated faces will be removed later on, but for now its totally
fine for both faces to co-exist to support Emacs versions <22.1 as well
as >=22.1.

[1]: http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=c430f7e23fc2c22f251ace4254e37dea1452dfc3
[2]: emacs-mirror/emacs@c430f7e

GH-75
@arcticicestudio arcticicestudio mentioned this issue Jan 5, 2020
Merged
arcticicestudio added a commit that referenced this issue Jan 5, 2020
@arcticicestudio
Migrate deprecated show-paren-X-face faces (#89)
a2b9038 
The `show-paren-match-face` and `show-paren-mismatch-face` face are
deprecated since Emacs version 22.1 [1,2] and were removed in Emacs 25.
To provide compatibilty to later EMacs version, the new
`show-paren-match` and `show-paren-mismatch` faces have been added.

The deprecated faces will be removed later on, but for now its totally
fine for both faces to co-exist to support Emacs versions <22.1 as well
as >=22.1.

[1]: http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=c430f7e23fc2c22f251ace4254e37dea1452dfc3
[2]: emacs-mirror/emacs@c430f7e

Closes GH-75
@arcticicestudio arcticicestudio removed their assignment Jan 5, 2020
arcticicestudio added a commit that referenced this issue Jan 8, 2020
@arcticicestudio
Migrate deprecated show-paren-X-face faces (#89)
a37d49f 
The `show-paren-match-face` and `show-paren-mismatch-face` face are
deprecated since Emacs version 22.1 [1,2] and were removed in Emacs 25.
To provide compatibilty to later EMacs version, the new
`show-paren-match` and `show-paren-mismatch` faces have been added.

The deprecated faces will be removed later on, but for now its totally
fine for both faces to co-exist to support Emacs versions <22.1 as well
as >=22.1.

[1]: http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=c430f7e23fc2c22f251ace4254e37dea1452dfc3
[2]: emacs-mirror/emacs@c430f7e

Closes GH-75
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
context-syntax scope-compatibility status-accepted type-feature
Projects
None yet
Milestone
0.5.0
Development

Successfully merging a pull request may close this issue.

Migrate deprecated show-paren-X-face faces nordtheme/emacs
2 participants
@arcticicestudio @janusvm