Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic support for auctex package #22

Merged
merged 2 commits into from
May 1, 2017

Conversation

justbur
Copy link
Contributor

@justbur justbur commented Mar 28, 2017

Hi, I like this theme. Thanks. I took a shot at fixing some of the main issues with the auctex faces.

Before:
nord-before

After:
nord-after

Copy link
Contributor

@arcticicestudio arcticicestudio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed the unecessary whitespace indentations and merge this PR. It'll be included in the next package release version.

nord-theme.el Outdated
`(font-latex-sectioning-5-face ((,class (:inherit font-latex-sectioning-0-face))))
`(font-latex-script-char-face ((,class (:inherit font-lock-warning-face))))
`(font-latex-string-face ((,class (:inherit font-lock-string-face))))
`(font-latex-warning-face ((,class (:inherit font-lock-warning-face))))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution 👍
Looks good, but can you remove the whitespace indents please? I know many developers like to indent code elements for the style, but in general its a bad code smell and makes it a great effort to maintain the code.

@arcticicestudio arcticicestudio merged commit c2cd1e8 into nordtheme:develop May 1, 2017
@arcticicestudio
Copy link
Contributor

Before

After

@arcticicestudio
Copy link
Contributor

🚢 Shipped with MELPA package release version 🏷 0.5.0.

@arcticicestudio arcticicestudio added this to the 0.3.0 milestone Jun 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants