Prefix internal names to avoid global namespace pollution #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sadly, Emacs Lisp has no namespaces, so every top level definition is visible to the entire universe. That includes variables and functions. This commit prefixes them to avoid "leaking" them in a way that could conflict with other code. The convention of `package--` is used to mirror the most current Emacs coding conventions. There are no functional changes from this modification. Closes nordtheme#66
arcticicestudio
approved these changes
Sep 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sadly, Emacs Lisp has no namespaces, so every top level definition is
visible to the entire universe. That includes variables and
functions.
This commit prefixes them to avoid "leaking" them in a way that could
conflict with other code. The convention of
package--is used tomirror the most current Emacs coding conventions.
There are no functional changes from this modification.
Closes #66