Skip to content

Commit

Permalink
Fix wrong Type- and JavaScript highlighting inherited from paren… (#116)
Browse files Browse the repository at this point in the history
As of IDE versions 2019.3.x, some TypeScript and JavaScript syntax
elements were not highlighted correctly. The following elements
inherited the colors from the "Darcula" parent scheme instead of the
language defaults defined by Nord:

- Global function
- Global variable
- Instance member function
- Instance member variable

These elements are now using explicitly defined colors instead to fix
the highlighting.

Fixes GH-115
  • Loading branch information
arcticicestudio authored Feb 11, 2020
1 parent 9d7913b commit 061fd42
Showing 1 changed file with 38 additions and 4 deletions.
42 changes: 38 additions & 4 deletions resources/themes/nord.xml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<property name="created">2016-09-24T21:08:20</property>
<property name="ide">idea</property>
<property name="ideVersion">2019.3.0.0</property>
<property name="modified">2019-12-02T09:34:36</property>
<property name="modified">2020-02-10T21:10:00</property>
<property name="originalScheme">Nord</property>
</metaInfo>
<colors>
Expand Down Expand Up @@ -1099,9 +1099,43 @@
</option>
<option name="JAVA_KEYWORD" baseAttributes="DEFAULT_KEYWORD" />
<option name="JAVA_VALID_STRING_ESCAPE" baseAttributes="DEFAULT_VALID_STRING_ESCAPE" />
<option name="JS.GLOBAL_FUNCTION" baseAttributes="DEFAULT_FUNCTION_DECLARATION" />
<option name="JS.GLOBAL_VARIABLE" baseAttributes="DEFAULT_GLOBAL_VARIABLE" />
<option name="JS.INSTANCE_MEMBER_FUNCTION" baseAttributes="DEFAULT_INSTANCE_METHOD" />
<option name="JS.CLASS">
<value>
<option name="FOREGROUND" value="8fbcbb" />
</value>
</option>
<option name="JS.EXPORTED.FUNCTION">
<value>
<option name="FOREGROUND" value="88c0d0" />
</value>
</option>
<option name="JS.EXPORTED.VARIABLE">
<value>
<option name="FOREGROUND" value="d8dee9" />
<option name="EFFECT_TYPE" value="1" />
</value>
</option>
<option name="JS.GLOBAL_FUNCTION">
<value>
<option name="FOREGROUND" value="88c0d0" />
</value>
</option>
<option name="JS.GLOBAL_VARIABLE">
<value>
<option name="FOREGROUND" value="8fbcbb" />
<option name="EFFECT_TYPE" value="1" />
</value>
</option>
<option name="JS.INSTANCE_MEMBER_FUNCTION">
<value>
<option name="FOREGROUND" value="88c0d0" />
</value>
</option>
<option name="JS.LOCAL_VARIABLE">
<value>
<option name="FOREGROUND" value="d8dee9" />
</value>
</option>
<option name="JS.REGEXP">
<value>
<option name="FOREGROUND" value="ebcb8b" />
Expand Down

0 comments on commit 061fd42

Please sign in to comment.