Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support new selected and inactive tab highlighting editor scheme keys #126

Closed
arcticicestudio opened this issue Feb 15, 2020 · 0 comments · Fixed by #130
Closed

Support new selected and inactive tab highlighting editor scheme keys #126

arcticicestudio opened this issue Feb 15, 2020 · 0 comments · Fixed by #130
Assignees
@arcticicestudio
Labels
context-ui scope-compatibility scope-ux type-feature
Milestone
0.11.0

Comments

@arcticicestudio
Copy link
Contributor

Reported by @Tom1206 in #120 (comment)

Related to #120

Selected and inactive tabs were previously styled using the corresponding ui.EditorTabs.* UI themey keys. Some of these keys are now deprecated or marked as "unknown" to the UI theme scheme validator. The highlighting is now controlled using the new TAB_SELECTED and TAB_SELECTED_INACTIVE editor color scheme keys added to the IDE platform code in JetBrains/intellij-community@bf26eb8.

In my opinion there are some keys that should not be placed in the editor scheme (including these both) and it feels like there is inconsistency between the UI theme API and editor color scheme API.
Anyway, in order to style tabs correctly again, both new editor scheme keys will be added using the same colors like the UI theme keys.
@arcticicestudio arcticicestudio added this to the 0.11.0 milestone Feb 15, 2020
@arcticicestudio arcticicestudio self-assigned this Feb 15, 2020
@arcticicestudio arcticicestudio changed the title Support new selected and inactive highlighting editor scheme keys Support new selected and inactive tab highlighting editor scheme keys Feb 15, 2020
arcticicestudio added a commit that referenced this issue Feb 15, 2020
@arcticicestudio
Support new selected and inactive tab highlighting editor scheme keys
bfbbb6c 
Selected and inactive tabs were previously styled using the
corresponding `ui.EditorTabs.*` UI themey keys. Some of these keys are
now deprecated or marked as "unknown" to the UI theme scheme validator.
The highlighting is now controlled using the new `TAB_SELECTED` and
`TAB_SELECTED_INACTIVE` editor color scheme keys added to the IDE
platform code in JetBrains/intellij-community@bf26eb8.

In my opinion there are some keys that should not be placed in the
editor scheme (including these both) and it feels like there is
inconsistency between the UI theme API and editor color scheme API.
Anyway, in order to style tabs correctly again, both new editor scheme
keys have been added using the same colors like the UI theme keys.

Reported by "Tom1206" (https://github.com/Tom1206) in #120 (comment)
Related to GH-120
GH-126
@arcticicestudio arcticicestudio mentioned this issue Feb 15, 2020
Merged
arcticicestudio added a commit that referenced this issue Feb 15, 2020
@arcticicestudio
Support new selected and inactive tab highlighting editor scheme… (#130)
a70716e 
Selected and inactive tabs were previously styled using the
corresponding `ui.EditorTabs.*` UI themey keys. Some of these keys are
now deprecated or marked as "unknown" to the UI theme scheme validator.
The highlighting is now controlled using the new `TAB_SELECTED` and
`TAB_SELECTED_INACTIVE` editor color scheme keys added to the IDE
platform code in JetBrains/intellij-community@bf26eb8.

In my opinion there are some keys that should not be placed in the
editor scheme (including these both) and it feels like there is
inconsistency between the UI theme API and editor color scheme API.
Anyway, in order to style tabs correctly again, both new editor scheme
keys have been added using the same colors like the UI theme keys.

Reported by "Tom1206" (https://github.com/Tom1206) in #120 (comment)
Related to GH-120
Closes GH-126
arcticicestudio added a commit that referenced this issue Feb 15, 2020
@arcticicestudio
Support new selected and inactive tab highlighting editor scheme… (#130)
7aa1f80 
Selected and inactive tabs were previously styled using the
corresponding `ui.EditorTabs.*` UI themey keys. Some of these keys are
now deprecated or marked as "unknown" to the UI theme scheme validator.
The highlighting is now controlled using the new `TAB_SELECTED` and
`TAB_SELECTED_INACTIVE` editor color scheme keys added to the IDE
platform code in JetBrains/intellij-community@bf26eb8.

In my opinion there are some keys that should not be placed in the
editor scheme (including these both) and it feels like there is
inconsistency between the UI theme API and editor color scheme API.
Anyway, in order to style tabs correctly again, both new editor scheme
keys have been added using the same colors like the UI theme keys.

Reported by "Tom1206" (https://github.com/Tom1206) in #120 (comment)
Related to GH-120
Closes GH-126
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arcticicestudio arcticicestudio

Labels
context-ui scope-compatibility scope-ux type-feature
Projects
None yet
Milestone
0.11.0
Development

Successfully merging a pull request may close this issue.

Support new selected and inactive tab highlighting editor scheme keys nordtheme/jetbrains
1 participant
@arcticicestudio