Test folder showing with background highlighted and hard to read

[axelitus]

On the new 0.5.0 UI theme using PhpStorm 2019.1 the tests folder is background-highlighted instead just coloring the folder icon. Moreover, the text color is hard to read due to contrast:

Also, the selected folder caret is hard to see because of contrast again.

My suggestion is to make the caret the same color as the text for selected items:

[axelitus]

Also, the context menu when hitting Alt+Enter > Import class is hard to read (and in my opinion the highlighting is reversed), though the autocomplete window shows correctly:

[arcticicestudio]

Thanks for the report 👍

These are some of the theme keys that are defined by the plugin theme scheme that I tried to figure out where they are used, but wasn't able to find all UI elements. I've added all currently unused keys in #45 so this might be one use case 😄
I'll take a look into it.

[arcticicestudio]

I've tried to reproduce the problem (with IntelliJ IDEA 2019.1 Ultimate Edition), but it works fine there.

The only UI keys that use nord13 and could cause this problem are

"Component": {
  "inactiveWarningFocusColor": "#ebcb8b",
  "warningFocusColor": "#ebcb8b"
}

There are also these two keys, but they should only affect notifications:

"Notification": {
  "ToolWindow": {
    "warningBackground": "#ebcb8b",
    "warningBorderColor": "#ebcb8b",
  }
}

Also the background color for the ValidationTooltip scope should not affect the class import popup.
Could you please try to modify the both Component scoped keys and see if this fixes the problem?

Regarding the background color of the test folder can you please make sure you haven't set a custom color for it through Settings ➜ Appearance & Behavior ➜ File Colors.

I've never used PHP at all so I'd need to install a trial version of PhpStorm to test this, but it might be faster if you could test these both changes 😄

[axelitus]

Alright, the first issue is fixed. Indeed it was because of Settings ➜ Appearance & Behavior ➜ File Colors. I have disabled it now. (Screenshots show this behavior and it also happens with IntelliJ).

File Colors enabled:

File Colors disabled:

Those settings are set by default (I've never changed them at all...)

I'll now look into the Alt+Enter context menu, probably it has been fixed too with this.

[axelitus]

All right. It hadn't been fixed but I know why now:

I have to uncheck all 3 checks in File Colors: Applying does not work as expected, you need to hit the Ok button for changes to apply completely:
[ ] Enable File colors (this affects the file tree view)
[ ] Use in Editor Tabs (this affects the file tabs, screenshot below)
[ ] Use in Project View (this affects the class import context menu)

Screenshot of tabs with Use in Editor Tabs enabled:

Screenshot of tabs with Use in Editor Tabs enabled:

Screenshot of class to import context menu with Use in Project View enabled:

Screenshot of class to import context menu with Use in Project View disabled:

[axelitus]

I don't know if it's possible to provide custom colors for the file colors, but I tried out changing them to a light green shaded color for the tests and it looks good to me. It just gives a slight hint of a test block. I'm using #363C48 (I got this using a background layer with #323846 as the base, and placing another layer on top with #A3BE8C and set its opacity to 3%) as a custom color:

Tabs look special enough too:
Test tab selected with color enabled:

Test tab selected with color disabled:

Test tab not selected:

The other menu is trickier because of the disabled text color, though I think the menu looks better without colors.

Let me know what you think.

[axelitus]

Finally, I ended up with this configuration:

With test color set to #363C48

[arcticicestudio]

Thanks for the detailed tests 💪

The colors are defined through the FileColor key, but these are only color suggestions and users can change it to whatever they like using the settings.

"FileColor": {
  "Blue": "#88c0d0",
  "Green": "#a3be8c",
  "Orange": "#d08770",
  "Rose": "#bf616a",
  "Violet": "#b48ead",
  "Yellow": "#ebcb8b"
}

I'd like to keep the current color since they are the base colors of the Nord palettes, but I'll open up a request in the JetBrain bugtracker to improve the theming support by allowing themes to change the foreground color. This way nord0 could be used forthe font which makes the text readable again.

Using a color with a opacity less than 100% will currently bug the hell out of the IDE. I've tried to use it for contrast in panels and popup menus, but ended up in calculating the HEX value because the IDE had visual glitches like duplicated text, streak lines on scroll and randomly changed the color of various elements.

I guess we can close this issue for now and I'll add some infos in the trouble shooting guide for the theme when users facing this kind of style depending on their settings.

[axelitus]

Yeah, my thoughts exactly from reading the Nord docs. Introducing a specific shade is not the way to go according to them, as the palette is to be kept narrowed to 15 colors.

Hopefully, JetBrains improves the customization and maybe in the future a properly supports opacity through HEXA values.

Thanks for the hard work!

[axelitus]

I found another place where it is not readable:

It's the debugging window, but I had it always in the Console tab, this is the Debugger tab.

This has nothing to do with the File Colors though, I have them disabled and it's still showing like that.

[arcticicestudio]

Looks like the File Color definitions are used by some other UI elements around the IDE, so I planned to remove them until JetBrains updates the theme API, but after some tests with reduced opacity it seems like the buggy rendering with transparent colors is not triggered by these colors.
The next release version will include changes for File Colors, reducing their opacity to 10% which is still enough to be recognizable, but should not destroy the readability of labels and appear too bright for most UI elements.

[axelitus]

The new colors in the 0.6.0 release look great!

[arcticicestudio]

Thanks, and in the end they are just quick suggestions and everyone can change them to whatever they like through the Custom color button in the File Colors settings 😄