Support background color styling of "diff" UI separator #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "diff" UI [1] renders a line to separate the different sections of a patch/diff that was added to the IDE platform code in JetBrains/intellij-community@f8de2a5. In order to style the elements the `DIFF_SEPARATORS_BACKGROUND` editor scheme key has been added to use `nord3` as background color. [1]: https://www.jetbrains.com/help/idea/comparing-files-and-folders.html [2]: https://github.com/Tom1206 Reported with proposed solution by @Tom1206 [2] in #120 (comment) Related to GH-120 GH-128
svengreb
approved these changes
Feb 15, 2020
arcticicestudio
deleted the
feature/gh-128-support-diff-separator-background-color
branch
arcticicestudio
added a commit
that referenced
this pull request
Feb 15, 2020
The "diff" UI [1] renders a line to separate the different sections of a patch/diff that was added to the IDE platform code in JetBrains/intellij-community@f8de2a5. In order to style the elements the `DIFF_SEPARATORS_BACKGROUND` editor scheme key has been added to use `nord3` as background color. [1]: https://www.jetbrains.com/help/idea/comparing-files-and-folders.html [2]: https://github.com/Tom1206 Reported with proposed solution by @Tom1206 [2] in #120 (comment) Related to GH-120 Closes GH-128
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #128
Thanks to @Tom1206 for the report in #120 (comment)
Before
After