-
-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Ruby, RDoc and ERB language support #145
Conversation
I will spend some more time tweaking this to match the other languages/editors in the nord ecosystem, but this is a huge step up at the moment. |
Hi @caleb 👋, thanks for your contribution 👍 This already looks great. I'll review and test the changes, but my first change request would be to explicitly define the syntax element attributes instead of inheriting from others. I'll review it in detail later on. Please note that it might take some time due to hundreds of other issues/PRs/support requests in other projects and my limited free time (combined with the current health situation of this world). |
Okay, I can update the theme to specify the colors rather than inherit. Once this looks good, I have a minor update for the clojure language to change keyword highlighting (e.g. Thanks! |
Hi there, It seems like the problem is still there. Have been patiently waiting since a few months, since I know that Sven is often very busy. Now I just want to ask if this is still in progress? Thanks in advance! |
Hi @arcticicestudio, Can you already tell, if this one will get reviewed and eventually merged into the next release? |
Hi @mariojackson, as far as I understand @caleb was about to update the PR to use the explicitly defined syntax element attributes instead of the inherited colors. |
Hi @arcticicestudio, That would be awesome if you could do that. If you can't, I could also wait of course or do it myself. I initially thought that this just had to be reviewed :) Thanks you Sven! |
I've adapted the changes and tested it locally. Looks good so far so I guess I'll push and merge this tomorrow to package and deploy the new release version 🚢 |
Added explicit support for Ruby's "RDoc" [1] for JetBrains RubyMine [2] and the official "Ruby" plugin for IntelliJ [3]. GH-145 [1]: https://github.com/ruby/rdoc [2]: https://www.jetbrains.com/ruby [3]: https://plugins.jetbrains.com/plugin/1293-ruby
Added explicit support for Ruby [1], RDoc [2] and ERB [3] for JetBrains RubyMine [4] and the official "Ruby" plugin for IntelliJ [5]. GH-145 [1]: https://www.ruby-lang.org [2]: https://github.com/ruby/rdoc [3]: https://en.wikipedia.org/wiki/ERuby [4]: https://www.jetbrains.com/ruby [5]: https://plugins.jetbrains.com/plugin/1293-ruby
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@caleb Thanks again for your contribution 👍
Unfortunately you've created this PR based on the develop
branch instead of a dedicated story branch so I also had to push the changes to the default branch of your fork.
The colors are now explicitly defined instead of relying on the (broken) inheritance system
I've also added dedicated support for RDoc.
Next to this I also adjusted some styles of some Ruby elements to better fit to the style of other languages.
Since I've never used Ruby I had to read something about the syntax to understand curious elements like Symbols.
The final results looks like this:
Add explicit Ruby, RDoc and ERB language support Added explicit support for Ruby [1], RDoc [2] and ERB [3] for JetBrains RubyMine [4] and the official "Ruby" plugin for IntelliJ [5]. [1]: https://www.ruby-lang.org [2]: https://github.com/ruby/rdoc [3]: https://en.wikipedia.org/wiki/ERuby [4]: https://www.jetbrains.com/ruby [5]: https://plugins.jetbrains.com/plugin/1293-ruby Co-authored-by: Arctic Ice Studio <[email protected]> Co-authored-by: Sven Greb <[email protected]>
@mariojackson Plugin version 0.13.0 is deployed to the JetBrains plugin registry and should be available soon 🚀 |
Thanks once again for your research, explanations and awesome work ✌🏽 I'm glad to be able to support you a little. Have a nice start into the week! |
Thanks, I wish you the same 😊 Unfortunately the Ruby plugin groups identifiers and structs/classes into the same syntax highlighting group so both are now using |
Mostly this patch just sets Ruby styles to inherit from the generic styles, but some styles needed to be manually set to make it consistent with the rest of the theme.
Before:
After: