Improve style for lines with both syntax and code inspection errors #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A line that contained both a syntax error as well as a "IntelliJ Code Inspection" (`ERRORS_ATTRIBUTES` editor scheme key) error was unreadable because both error detection scopes/types applied their different highlighting styles resulting in a background and foreground color colorized with `nord11`. This made it impossible to read the text. Some tests using a opacity of 60% for `nord11` as background color instead resulted in a "dirty redish" color due to the miy with thge base editor background color. Therefore a better style of highlighting these errors has been designed. The new style doesn't make use of a background color at all based on the fact that it is a duplicate highlighting. If there's a syntax error the invalid tokens will be highlighted with `nord11` due to the syntax error so there is no need to additionally colorize the background with `nord11` which is the main reson for the unreadable text. The new styles for "Code Inspection" errors has been simplified to use `nord11` as foreground color with a bold underline and the already used error stripe next to the line numbers. This design decision also comes with a change for the "Unknown Symbol" highlighting (`WRONG_REFERENCES_ATTRIBUTES` color scheme key) that now uses a dotted underline instead to differentiate from the new error styles. GH-60
svengreb
approved these changes
Jun 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A line that contained both a syntax error as well as a IntelliJ Code Inspection (
ERRORS_ATTRIBUTESeditor scheme key) error was unreadable because both error detection scopes/types applied their different highlighting styles resulting in a background and foreground color colorized withnord11. This made it impossible to read the text.Highlighting resulting in unreadable text when combined with error text
Some tests using a opacity of 60% for
nord11as background color instead resulted in a “dirty redish“ color due to the miy with the base editor background color.Reduced opacity of 60%
Therefore a better style of highlighting these errors has been designed.
The new style doesn't make use of a background color at all based on the fact that it is a duplicate highlighting. If there's a syntax error the invalid tokens will be highlighted with
nord11due to the syntax error so there is no need to additionally colorize the background withnord11which is the main reason for the unreadable text.The new styles for Code Inspection errors has been simplified to use
nord11as foreground color with a bold underline and the already used error stripe next to the line numbers. This design decision also comes with a change for the “Unknown Symbol“ highlighting (WRONG_REFERENCES_ATTRIBUTEScolor scheme key) that now uses a dotted underline instead to differentiate from the new error styles.Improved error and Unknown Symbol styles