Uninstall option for install script #3
Comments
|
Wiping existing config without confirmation and warning is pretty rude and not what i expected. |
|
Any updates here? I just tried to run install.sh and get all my local settings wiped and I had to restore all of them manually. It is really unexpected and frustrating behaviour. |
|
This should be fixed! |
arcticicestudio
added a commit
that referenced
this issue
Apr 8, 2020
@TolichP [1] reported in #3 [2 `install.sh` script replaced the `config` file which led to configuration/data loss. This was caused by the `-f` flag passed to the `cp` command [3] which forced to override existing files. This is a really critical bug and the the solution to provide a script that automatically handles the simple task of copying a file has never been a good idea at all. Therefore the script was removed and the documentation has been adjusted to provide manual installation steps instead like in other port projects, e.g. Nord Alacritty [4]. The manual steps are quite simple and the knowledge can be expected of users since these are basic operations when running a Unix system. Projects like Terminato, that require to modify the main user configuration file instead of providing a way to load features like themes from dedicated file, are always way harder to support as a theme author. Anyway, there are plans to unify the installation of Nord port projects through one universal automation tool, but there is currently no ETA. [1]: https://github.com/TolichP [2]: #3 (comment) [3]: https://github.com/arcticicestudio/nord-terminator/blob/af29e150a531f7984d362f4aa135c1bfffd13c45/install.sh#L83 [4]: https://github.com/arcticicestudio/nord-alacritty GH-12
arcticicestudio
added a commit
that referenced
this issue
Apr 8, 2020
) @TolichP [1] reported in #3 [2 `install.sh` script replaced the `config` file which led to configuration/data loss. This was caused by the `-f` flag passed to the `cp` command [3] which forced to override existing files. This is a really critical bug and the the solution to provide a script that automatically handles the simple task of copying a file has never been a good idea at all. Therefore the script was removed and the documentation has been adjusted to provide manual installation steps instead like in other port projects, e.g. Nord Alacritty [4]. The manual steps are quite simple and the knowledge can be expected of users since these are basic operations when running a Unix system. Projects like Terminato, that require to modify the main user configuration file instead of providing a way to load features like themes from dedicated file, are always way harder to support as a theme author. Anyway, there are plans to unify the installation of Nord port projects through one universal automation tool, but there is currently no ETA. [1]: https://github.com/TolichP [2]: #3 (comment) [3]: https://github.com/arcticicestudio/nord-terminator/blob/af29e150a531f7984d362f4aa135c1bfffd13c45/install.sh#L83 [4]: https://github.com/arcticicestudio/nord-alacritty Fixes GH-12
arcticicestudio
added
resolution-obsolete
resolution-revoked
and removed
type-improvement
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Implement a
uninstalloption to allow users to remove the local installed color theme file again including a optional name parameter for custom named theme files.The user should be asked to confirm this process before removing the file.
The text was updated successfully, but these errors were encountered: